Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: handle headers with tokens better #3535

Closed
niemeyer opened this issue Apr 15, 2012 · 3 comments
Closed

net/http: handle headers with tokens better #3535

niemeyer opened this issue Apr 15, 2012 · 3 comments
Labels
FrozenDueToAge

Comments

@niemeyer
Copy link
Contributor 

The Connection and Expect headers are being poorly compared within the http package. The
RFC uses the notation 1#token for the value of these headers, which means
comma-separated with optional spacing. The http package does ad-hoc strings.Contains and
straight equality checks depending on the situation, which are both incorrect.
@bradfitz
Copy link
Contributor

Comment 2:

Owner changed to @bradfitz.

Status changed to Started.

@bradfitz
Copy link
Contributor

Comment 3:

http://golang.org/cl/6245060

@bradfitz
Copy link
Contributor

Comment 4:

This issue was closed by revision 469e3a9.

Status changed to Fixed.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bradfitz @niemeyer @gopherbot