Issue 6245060: code review 6245060: net/http: correct and faster hasToken

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6245060: code review 6245060: net/http: correct and faster hasToken (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 12 months ago by bradfitz

Modified:
11 years, 11 months ago

Reviewers:
rsc

CC:
golang-dev, dsymonds

Visibility:
Public.

Description

net/http: correct and faster hasToken Fixes issue 3535

Patch Set 2 : diff -r 050271fb599f https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 050271fb599f https://go.googlecode.com/hg/ #

Total comments: 1

Patch Set 4 : diff -r d0bc02d414c7 https://go.googlecode.com/hg/ #

Total comments: 1

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -8 lines)			Patch
M	src/pkg/net/http/header.go	View	1 2 3	1 chunk	+35 lines, -0 lines	1 comment	Download
M	src/pkg/net/http/header_test.go	View	1	1 chunk	+43 lines, -0 lines	0 comments	Download
M	src/pkg/net/http/request.go	View	1	1 chunk	+0 lines, -8 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bradfitz

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/

11 years, 12 months ago (2012-05-27 01:18:05 UTC) #1

dsymonds

LGTM http://codereview.appspot.com/6245060/diff/5001/src/pkg/net/http/header.go File src/pkg/net/http/header.go (right): http://codereview.appspot.com/6245060/diff/5001/src/pkg/net/http/header.go#newcode81 src/pkg/net/http/header.go:81: // case-insensitve, with space or comma boundaries. "insensitive"

11 years, 11 months ago (2012-05-28 00:19:21 UTC) #2

bradfitz

*** Submitted as http://code.google.com/p/go/source/detail?r=1786f1514ab5 *** net/http: correct and faster hasToken Fixes issue 3535 R=golang-dev, dsymonds ...

11 years, 11 months ago (2012-05-28 17:55:44 UTC) #3

rsc

11 years, 11 months ago (2012-05-29 18:09:00 UTC) #4

http://codereview.appspot.com/6245060/diff/10001/src/pkg/net/http/header.go
File src/pkg/net/http/header.go (right):

http://codereview.appspot.com/6245060/diff/10001/src/pkg/net/http/header.go#n...
src/pkg/net/http/header.go:93: if b := v[sp]; b != token[0] && b|0x20 !=
token[0] {
You need a comment or two for this, explaining what the |0x20 is doing and why
it doesn't matter that it's wrong for non-letters.

Expand All Messages | Collapse All Messages