Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/sys/unix: remove nacl build tag from dirent code #33391

Closed
smasher164 opened this issue Jul 31, 2019 · 1 comment
Closed

x/sys/unix: remove nacl build tag from dirent code #33391

smasher164 opened this issue Jul 31, 2019 · 1 comment
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@smasher164
Copy link
Member

CL 128110043 deletes nacl from x/sys/unix, but a later change CL 38758 copies stdlib syscall code over for non-nacl platforms. However, x/unix/dirent.go#L5 still includes +build nacl, which should be removed.
@gopherbot gopherbot added this to the Unreleased milestone Jul 31, 2019
@smasher164 smasher164 changed the title x/sys/unix remove nacl build tag from dirent code x/sys/unix: remove nacl build tag from dirent code Jul 31, 2019
@ianlancetaylor ianlancetaylor added help wanted NeedsFix The path to resolution is known, but the work has not been done. labels Jul 31, 2019
@gopherbot
Copy link

Change https://golang.org/cl/188361 mentions this issue: x/sys/unix: remove nacl build tag from dirent code

@golang golang locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@ianlancetaylor @gopherbot @smasher164