Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(92)

Issue 128110043: code review 128110043: go.sys/unix: delete nacl (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 8 months ago by r
Modified:
9 years, 8 months ago
Reviewers:
dave, minux, rsc
CC:
rsc, dave_cheney.net, golang-codereviews
Visibility:
Public.

Description

go.sys/unix: delete nacl It's a peculiar environment that probably doesn't belong here. We can bring it back easily if we need it.

Patch Set 1 #

Patch Set 2 : diff -r d7b2324e104c1e05fb5b21ac2d4527f501da2598 https://code.google.com/p/go.sys #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4678 lines) Patch
R unix/asm_nacl_386.s View 1 chunk +0 lines, -43 lines 0 comments Download
R unix/asm_nacl_amd64p32.s View 1 chunk +0 lines, -41 lines 0 comments Download
R unix/asm_nacl_arm.s View 1 chunk +0 lines, -43 lines 0 comments Download
M unix/env_unix.go View 1 chunk +1 line, -1 line 0 comments Download
R unix/fd_nacl.go View 1 chunk +0 lines, -326 lines 0 comments Download
R unix/fs_nacl.go View 1 chunk +0 lines, -832 lines 0 comments Download
M unix/mkall.sh View 1 chunk +0 lines, -12 lines 0 comments Download
M unix/mksyscall.pl View 3 chunks +0 lines, -8 lines 0 comments Download
R unix/net_nacl.go View 1 chunk +0 lines, -912 lines 0 comments Download
R unix/srpc_nacl.go View 1 chunk +0 lines, -822 lines 0 comments Download
R unix/syscall_nacl.go View 1 chunk +0 lines, -311 lines 0 comments Download
R unix/syscall_nacl_386.go View 1 chunk +0 lines, -32 lines 0 comments Download
R unix/syscall_nacl_amd64p32.go View 1 chunk +0 lines, -32 lines 0 comments Download
R unix/syscall_nacl_arm.go View 1 chunk +0 lines, -32 lines 0 comments Download
R unix/tables_nacl.go View 1 chunk +0 lines, -324 lines 0 comments Download
R unix/time_nacl_386.s View 1 chunk +0 lines, -11 lines 0 comments Download
R unix/time_nacl_amd64p32.s View 1 chunk +0 lines, -11 lines 0 comments Download
R unix/time_nacl_arm.s View 1 chunk +0 lines, -11 lines 0 comments Download
R unix/unzip_nacl.go View 1 chunk +0 lines, -685 lines 0 comments Download
R unix/zsyscall_nacl_386.go View 1 chunk +0 lines, -63 lines 0 comments Download
R unix/zsyscall_nacl_amd64p32.go View 1 chunk +0 lines, -63 lines 0 comments Download
R unix/zsyscall_nacl_arm.go View 1 chunk +0 lines, -63 lines 0 comments Download

Messages

Total messages: 6
r
Hello rsc (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.sys
9 years, 8 months ago (2014-08-12 23:04:43 UTC) #1
dave_cheney.net
LGTM. I agree with rsc that there isn't a strong case to handle nacl in ...
9 years, 8 months ago (2014-08-12 23:33:04 UTC) #2
rsc
LGTM
9 years, 8 months ago (2014-08-12 23:48:54 UTC) #3
r
*** Submitted as https://code.google.com/p/go/source/detail?r=42f74880d132&repo=sys *** go.sys/unix: delete nacl It's a peculiar environment that probably doesn't ...
9 years, 8 months ago (2014-08-12 23:58:22 UTC) #4
minux
what about the IRT support for nacl? i think we will need go.sys/nacl package then?
9 years, 8 months ago (2014-08-13 00:46:13 UTC) #5
rsc
9 years, 8 months ago (2014-08-13 01:18:43 UTC) #6
we don't need it now.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b