Skip to content

x/tools/cmd/godoc: url flag's response recorder ignores body [1.12 backport] #30314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Feb 19, 2019 · 5 comments
Closed

x/tools/cmd/godoc: url flag's response recorder ignores body [1.12 backport] #30314

gopherbot opened this issue Feb 19, 2019 · 5 comments
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Milestone
Go1.12

Comments

@gopherbot
Copy link
Contributor

@rhysh requested issue #30261 to be considered for backport to the next 1.12 minor release.

@gopherbot please backport to 1.12
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 19, 2019
@gopherbot gopherbot mentioned this issue Feb 19, 2019
Closed
@gopherbot gopherbot added this to the Unreleased milestone Feb 19, 2019
@gopherbot
Copy link
Contributor Author

Change https://golang.org/cl/162985 mentions this issue: cmd/godoc: fix -url flag, add tests

gopherbot pushed a commit to golang/tools that referenced this issue Feb 19, 2019
@rhysh @bradfitz
[release-branch.go1.12] cmd/godoc: fix -url flag, add tests
49d818b 
This change adds a small number of integration tests for the godoc
command's -url flag, confirming that the behavior matches the local http
server tests in those cases. It fixes three bugs which prevent the -url
flag from working currently.

Fixes golang/go#30314

Change-Id: I0ca1fe81f9f186d0ca02b31674cc8654af434e92
Reviewed-on: https://go-review.googlesource.com/c/162907
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
(cherry picked from commit bb2d419)
Reviewed-on: https://go-review.googlesource.com/c/162985
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
@agnivade
Copy link
Contributor

@dmitshur - Any idea why gopherbot didn't close this ?

@dmitshur
Copy link
Contributor

I've investigated. The reason gopherbot didn't close this issue when CL 162985 was merged, as part of its "close cherry pick issues" task, is because this issue did not have a patch release milestone (e.g., one like Go1.11.6). The relevant code is here.

@dmitshur dmitshur modified the milestones: Unreleased, Go1.12 Feb 21, 2019
@dmitshur dmitshur mentioned this issue Feb 21, 2019
Closed
@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 25, 2019
@dmitshur
Copy link
Contributor

@andybons I suspect you didn't intentionally modify the milestone, it probably happened as part of making the Go 1.12 release.

For context, this is a backport issue for 1.12, and it has already been resolved via CL 162985. It didn't get closed by gopherbot due to a bug (#30342), which has a fix (CL 163205) waiting on review.

I'm going to move the milestone back to 1.12. I could close the issue myself, but I'd prefer to deploy the gopherbot fix and confirm that gopherbot closes it.

@dmitshur dmitshur modified the milestones: Go1.13, Go1.12 Feb 28, 2019
gopherbot pushed a commit to golang/build that referenced this issue Mar 1, 2019
@dmitshur
cmd/gopherbot: support closing major release cherry-pick issues
f7b2718 
The "close cherry pick issues" task has been working to close
cherry-pick issues when CLs are merged to release branches,
but only for issues with milestones like like 1.12.1, 1.12.2,
1.12.3, etc., not ones like 1.12. This change fixes that.

Output from a -dry-run run after this change:

	$ go run . -dry-run -only-run="close cherry pick issues"
	close-cherry-pick [dry-run]
		https://golang.org/issue/30314  x/tools/cmd/godoc: url flag's response recorder ignores body [1.12 backport]
	2019/02/21 14:00:43 [dry-run] would add comment to github.com/golang/go/issues/30314: Closed by merging 49d818b07734fb3230f2d00bc5d4453348348d24 to release-branch.go1.12.
	2019/02/21 14:00:43 [dry-run] would close golang.org/issue/30314
	2019/02/21 14:00:43 gopherbot ran in 217.391921ms

Fixes golang/go#30342

Change-Id: I93528e6cf724aba1894a7c640fbb75ec42bb2006
Reviewed-on: https://go-review.googlesource.com/c/163205
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging 49d818b07734fb3230f2d00bc5d4453348348d24 to release-branch.go1.12.

@golang golang locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickCandidate Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.12
Development

No branches or pull requests
4 participants
@andybons @agnivade @dmitshur @gopherbot