Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/poly1305: Fails to build with Go1.3 on ARM, missing textflag.h #11448

Closed
fd0 opened this issue Jun 28, 2015 · 5 comments
Closed

x/crypto/poly1305: Fails to build with Go1.3 on ARM, missing textflag.h #11448

fd0 opened this issue Jun 28, 2015 · 5 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@fd0
Copy link

fd0 commented Jun 28, 2015

In golang/crypto@4d48e5f, an efficient ARM assembler implementation for poly1305 was added. Unfortunately, this assembler code includes textflag.h, which is not available in Go 1.3, so compiling fails for ARM:

$ go version
go version go1.3.3 linux/amd64
$ GOARCH=arm GOOS=linux go build
# golang.org/x/crypto/poly1305
../../../../../golang.org/x/crypto/poly1305/poly1305_arm.s:17 syntax error, last name: RODATA
../../../../../golang.org/x/crypto/poly1305/poly1305_arm.s:22 syntax error, last name: NOSPLIT
[...]

This issue is similar to #9211.

Is Go 1.3 not supported for the crypto package any more? Is it maybe possible to change the assembler code to not use textflag.h?
@ianlancetaylor ianlancetaylor added this to the Unreleased milestone Jul 11, 2015
@ianlancetaylor
Copy link
Contributor

The new ARM code needs the same fix as https://golang.org/cl/154120043.

@fd0
Copy link
Author

fd0 commented Jul 11, 2015

This sounds like an easy task, shall I try it and submit a CL?

@ianlancetaylor
Copy link
Contributor

Sure, thanks.

@fd0
Copy link
Author

fd0 commented Jul 11, 2015

Submitted as https://go-review.googlesource.com/12033

@gopherbot
Copy link

CL https://golang.org/cl/12033 mentions this issue.

@fd0 fd0 mentioned this issue Apr 18, 2016
Closed
@golang golang locked and limited conversation to collaborators Jul 11, 2016
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@fd0 @ianlancetaylor
poly1305/arm: allow building with Go 1.3
51cd892 
This is the same as https://golang.org/cl/154120043

Since the file textflag.h is not available on Go 1.3, the macros defined
in textflag.h are replaced with their respective value.

Fixes golang/go#11448

Change-Id: I0d4aed67b7afe50d8e4e88915edd2cefeac4cc96
Reviewed-on: https://go-review.googlesource.com/12033
Reviewed-by: Ian Lance Taylor <iant@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@fd0 @ianlancetaylor
poly1305/arm: allow building with Go 1.3
ff6d475 
This is the same as https://golang.org/cl/154120043

Since the file textflag.h is not available on Go 1.3, the macros defined
in textflag.h are replaced with their respective value.

Fixes golang/go#11448

Change-Id: I0d4aed67b7afe50d8e4e88915edd2cefeac4cc96
Reviewed-on: https://go-review.googlesource.com/12033
Reviewed-by: Ian Lance Taylor <iant@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@fd0 @ianlancetaylor
poly1305/arm: allow building with Go 1.3
5696f08 
This is the same as https://golang.org/cl/154120043

Since the file textflag.h is not available on Go 1.3, the macros defined
in textflag.h are replaced with their respective value.

Fixes golang/go#11448

Change-Id: I0d4aed67b7afe50d8e4e88915edd2cefeac4cc96
Reviewed-on: https://go-review.googlesource.com/12033
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@fd0 @ianlancetaylor @gopherbot