Issue 154120043: code review 154120043: curve25519, poly1305: change last CL to build with Go 1.3

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 154120043: code review 154120043: curve25519, poly1305: change last CL to build with Go 1.3 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 7 months ago by iant

Modified:
9 years, 7 months ago

Reviewers:
agl1

CC:
agl1, golang-codereviews

Visibility:
Public.

Description

curve25519, poly1305: change last CL to build with Go 1.3 It also still works with Go 1.4.

Patch Set 1 #

Patch Set 2 : diff -r e84380f807716b7953bc02c8e1504f73bbc60932 https://code.google.com/p/go.crypto #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -26 lines)			Patch
	M	curve25519/const_amd64.s	View		1 chunk	+4 lines, -6 lines	0 comments	Download
	M	poly1305/const_amd64.s	View		1 chunk	+18 lines, -20 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello agl@golang.org (cc: golang-codereviews@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go.crypto

9 years, 7 months ago (2014-10-08 01:06:38 UTC) #1

iant

9 years, 7 months ago (2014-10-08 01:09:35 UTC) #3

*** Submitted as
https://code.google.com/p/go/source/detail?r=ae00e4482c53&repo=crypto ***

curve25519, poly1305: change last CL to build with Go 1.3

It also still works with Go 1.4.

LGTM=agl
R=agl
CC=golang-codereviews
https://codereview.appspot.com/154120043

Expand All Messages | Collapse All Messages