Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/review/git-codereview: weird error when trying to commit a merge #9981

Closed
4ad opened this issue Feb 24, 2015 · 2 comments
Closed

x/review/git-codereview: weird error when trying to commit a merge #9981

4ad opened this issue Feb 24, 2015 · 2 comments

Comments

@4ad
Copy link
Member

4ad commented Feb 24, 2015

I have no idea what this means.

: xgene:go; git commit
git log --topo-order --format=format:%H%x00%h%x00%P%x00%B%x00%s%x00 origin/master..refs/heads/new2.arm64 --
fatal: bad revision 'origin/master..refs/heads/new2.arm64'

git-codereview: exit status 128
@mikioh mikioh changed the title x/review/git-codereview: weird error when trying to commit a merge git-codereview: weird error when trying to commit a merge Feb 24, 2015
@josharian
Copy link
Contributor

What do git rev-parse origin/master and git rev-parse refs/heads/new2.arm64 show? In theory, that command should display all commits in the range between those two commits.

@4ad
Copy link
Member Author

4ad commented Feb 24, 2015

Sorry, no idea, I deleted the hook and did what I had to do.

But if it happens again (it happened a few times already) I will try those commands.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title git-codereview: weird error when trying to commit a merge x/review/git-codereview: weird error when trying to commit a merge Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-review label Apr 14, 2015
@rsc rsc closed this as completed Jan 29, 2016
@golang golang locked and limited conversation to collaborators Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants