-
Notifications
You must be signed in to change notification settings - Fork 18k
syscall: support linux variants that don't support deprecated syscalls #9974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Milestone
Comments
davecheney
added a commit
that referenced
this issue
Feb 24, 2015
Rebuild the zsyscall_linux_*.go files in preperation for #9974 The only change is the ppc64/ppc64le files which were not rebuilt when syscall.use was added. Change-Id: I804c63731e4900c782025de04ea3585d99688958 Reviewed-on: https://go-review.googlesource.com/5831 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
davecheney
added a commit
that referenced
this issue
Feb 25, 2015
Updates #9974 This proposal moves the definition of Pipe an Pipe2 from the generic syscall_linux.go to the GOOS specific variants. This is in preparation for the arm64 port. For platforms where pipe2(2) is not supported in the minimum 2.6.23 kernel, amd64 and 386, we retain pipe(2). For all other platforms pipe(2) is removed and Pipe forwards to pipe2(2). Because mksycall.pl does not sort symbols before generating the output file the diff includes some unavoidable code moves as Pipe and Pipe2 are processed latter in the run. Discussion: https://groups.google.com/forum/#!topic/golang-dev/zpeFtN2z5Fc Change-Id: Ie26d6761eeb9760dbaff974ee8bc0d57a9ceaee4 Reviewed-on: https://go-review.googlesource.com/5833 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org> Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
davecheney
added a commit
that referenced
this issue
Feb 25, 2015
Updates #9974 This proposal moves the definition of Dup2 from the generic syscall_linux.go to the GOOS specific variants. This is in preparation for the arm64 port. For all existing platforms Dup2 is not affected. When arm64 is added we'll use either a forwarding method to Dup3 or //sysnb Dup2(oldfd int, newfd int) (err error) = SYS_DUP3 Because mksycall.pl does not sort symbols before generating the output file the diff includes some unavoidable code moves as Dup2 is processed latter in the run. Discussion: https://groups.google.com/forum/#!topic/golang-dev/zpeFtN2z5Fc Change-Id: Icdedf55bb29e749c4230e1ee371bf9d0bd0cfb38 Reviewed-on: https://go-review.googlesource.com/5835 Reviewed-by: Minux Ma <minux@golang.org> Run-TryBot: Dave Cheney <dave@cheney.net>
davecheney
added a commit
that referenced
this issue
Feb 25, 2015
Updates #9974 The *at family of syscalls requires some constants to be defined in the syscall package for linux. Add the necessary constants and regenerate the ztypes_linux_*.go files. Change-Id: I6df343fef7bcacad30d36c7900dbfb621465a4fe Reviewed-on: https://go-review.googlesource.com/5836 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
davecheney
added a commit
that referenced
this issue
Feb 26, 2015
Updates #9974 This proposal tackles the body of syscalls which have been replaced, and are now deprecated in linux. This is needed for the arm64 port as arm64 is the first linux architecture to remove the "legacy" forms of these syscalls. The *AT variants were added in kernel 2.6.16, so well before our 2.6.23 cutoff (hey, it'll even work on RHEL5). Discussion: https://groups.google.com/forum/#!topic/golang-dev/zpeFtN2z5Fc Change-Id: I473a7c9a295d6f776fcdc75dcce06cbe9e3564ee Reviewed-on: https://go-review.googlesource.com/5837 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
davecheney
added a commit
that referenced
this issue
Mar 10, 2015
Updates #9974 This change is in preparation for merging the arm64 platform. Arm64 does not support SYS_DUP2 at all, so define a new constant to be the minimum dup(2) version supported. This constant defaults to SYS_DUP2 on all existing platforms. Change-Id: If405878105082c7c880f8541c1491970124c9ce4 Reviewed-on: https://go-review.googlesource.com/7123 Reviewed-by: Minux Ma <minux@golang.org> Run-TryBot: Minux Ma <minux@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Dave Cheney <dave@cheney.net>
Looks like this was done by making, say, Open call Openat. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Whew, that issue title is a mouthful.
The issue in question is newer linux ports, amr64 being the one in question, have dropped support for a number of "legacy" syscalls, ie
open(2)
was replaced byopenat(2)
, and so on.The ppc64 port also faced similar issues (
select(2)
has been replaced bypselect6(2)
for example), but not as severe.The text was updated successfully, but these errors were encountered: