Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509: parseCertificate fails if Cert Policy extension is critical #9964

Closed
mvanotti opened this issue Feb 23, 2015 · 1 comment
Closed

crypto/x509: parseCertificate fails if Cert Policy extension is critical #9964

mvanotti opened this issue Feb 23, 2015 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@mvanotti
Copy link

Minimal Test Case: http://play.golang.org/p/ihE8Lkqw66
At the end there's a certificate with a Cert Policy extension marked as critical.

parseCertificate fails because it is missing a continue at the end of case 32.
https://github.com/golang/go/blob/fe40cdd75676398/src/crypto/x509/x509.go#L1051-L1061

Refer to RFC 5280 Section 4.2.1.4

Adding a simple continue at the end will fix the issue.
@agl agl self-assigned this Feb 23, 2015
@agl
Copy link
Contributor

agl commented Feb 23, 2015

https://go-review.googlesource.com/#/c/5670/

@agl agl closed this as completed in c2317db Feb 24, 2015
@mikioh mikioh added this to the Go1.5 milestone Feb 24, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
@rsc rsc unassigned agl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@agl @mikioh @mvanotti @gopherbot