Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: reject commit messages with non-standard form #9958

Closed
josharian opened this issue Feb 22, 2015 · 2 comments
Closed

x/review/git-codereview: reject commit messages with non-standard form #9958

josharian opened this issue Feb 22, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor

In particular, they should be of the form <some components]: <message>.

This came up in CL 5542.
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title git-codereview: reject commit messages with non-standard form x/review/git-codereview: reject commit messages with non-standard form Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-review label Apr 14, 2015
@cmarcelo
Copy link
Contributor

Duplicate of #9254?

For the reference: it was fixed by golang/review@07daa7f that performs the check, asking "y/n" if the commit message doesn't follow the convention.

@josharian
Copy link
Contributor Author

I guess so. The problem occurred after the fix mentioned, but I'll close this for now, since it appears to be a duplicate and it has sat dormant for a long time.

@golang golang locked and limited conversation to collaborators Feb 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@cmarcelo @josharian @mikioh @rsc @gopherbot