Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/present: slides doesn't work correctly if -play=false #9878

Closed
minux opened this issue Feb 14, 2015 · 3 comments
Closed

x/tools/cmd/present: slides doesn't work correctly if -play=false #9878

minux opened this issue Feb 14, 2015 · 3 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@minux
Copy link
Member

minux commented Feb 14, 2015

I think it's because jQuery is bundled with /play.js, but it's only
referenced in the HTML if -play is enabled.
@adg adg mentioned this issue Feb 25, 2015
Closed
@parkr
Copy link

parkr commented Feb 25, 2015

Is there a CL for this?

@adg
Copy link
Contributor

adg commented Feb 25, 2015

@parkr no

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title cmd/present: slides doesn't work correctly if -play=false x/tools/cmd/present: slides doesn't work correctly if -play=false Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@gopherbot
Copy link

CL https://golang.org/cl/20288 mentions this issue.

jjneely pushed a commit to jjneely/present that referenced this issue Nov 4, 2016
@kostya-sh @adg
cmd/present: fix slides movement when -play=false
7523555 
Fix by removing jQuery usage from slides.js as jquery.js is only
available when play.js is included.

Fixes golang/go#9878

Change-Id: I5793350105b138d7b7645f11d814e1d2f573a73e
Reviewed-on: https://go-review.googlesource.com/20288
Reviewed-by: Andrew Gerrand <adg@golang.org>
@golang golang locked and limited conversation to collaborators Mar 13, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@rsc @minux @parkr @adg @gopherbot