New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syscall: NewCallback panics when given a callback function with no input parameters #9871
Labels
Milestone
Comments
minux
changed the title
On Windows, syscall.NewCallback panics when given a callback function with no input parameters
syscall: NewCallback panics when given a callback function with no input parameters
Feb 14, 2015
It has been fixed on tip, and the following patch should fix it in 1.4.1.
I'm not sure if we want to fix it for 1.4.2 or not. Tentatively labeled Go1.4.2. |
@minux Thanks! |
@minux your patch does not apply cleanly to release-branch.go1.4. Did I miss a change go by? |
I will send a CL against release-branch.go1.4. |
minux
added a commit
that referenced
this issue
Feb 17, 2015
…h no input params on windows Fixes #9871 for Go 1.4. Change-Id: I550a5bdb29e9a872652e0dd468a434227d7d9502 Reviewed-on: https://go-review.googlesource.com/4937 Run-TryBot: Minux Ma <minux@golang.org> Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 25, 2018
…h no input params on windows Fixes golang#9871 for Go 1.4. Change-Id: I550a5bdb29e9a872652e0dd468a434227d7d9502 Reviewed-on: https://go-review.googlesource.com/4937 Run-TryBot: Minux Ma <minux@golang.org> Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jun 26, 2018
…h no input params on windows Fixes golang#9871 for Go 1.4. Change-Id: I550a5bdb29e9a872652e0dd468a434227d7d9502 Reviewed-on: https://go-review.googlesource.com/4937 Run-TryBot: Minux Ma <minux@golang.org> Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 9, 2018
…h no input params on windows Fixes golang#9871 for Go 1.4. Change-Id: I550a5bdb29e9a872652e0dd468a434227d7d9502 Reviewed-on: https://go-review.googlesource.com/4937 Run-TryBot: Minux Ma <minux@golang.org> Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 20, 2018
…h no input params on windows Fixes golang#9871 for Go 1.4. Change-Id: I550a5bdb29e9a872652e0dd468a434227d7d9502 Reviewed-on: https://go-review.googlesource.com/4937 Run-TryBot: Minux Ma <minux@golang.org> Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
wheatman
pushed a commit
to wheatman/go-akaros
that referenced
this issue
Jul 30, 2018
…h no input params on windows Fixes golang#9871 for Go 1.4. Change-Id: I550a5bdb29e9a872652e0dd468a434227d7d9502 Reviewed-on: https://go-review.googlesource.com/4937 Run-TryBot: Minux Ma <minux@golang.org> Reviewed-by: Rob Pike <r@golang.org> Reviewed-by: Alex Brainman <alex.brainman@gmail.com> Reviewed-by: Andrew Gerrand <adg@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Go 1.4.1 on Windows XP 32-bit (386)
The below program panics:
However this program does not panic:
It seems that
syscall.NewCallback
requires the callback function to have at least one input parameter. Note that in Go 1.3.3 it did not require the callback function to have at least one input parameter, so to avoid breaking existing code, it should probably continue not to require it. However, if it does continue to require an input parameter, it should at least return a human-readable error and the documentation for the function should make that clear.Note also that I get the same result with syscall.NewCallbackCDecl.
The text was updated successfully, but these errors were encountered: