Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: use java:openjdk docker base image #9823

Closed
proppy opened this issue Feb 10, 2015 · 2 comments
Closed

x/mobile: use java:openjdk docker base image #9823

proppy opened this issue Feb 10, 2015 · 2 comments

Comments

@proppy
Copy link
Contributor

proppy commented Feb 10, 2015

What do you think of using the official openjdk image as the base for the docker image instead of ubuntu?

Is there a specific reason you default on installing the oracle JDK?

Just tested that android 21 + openjdk seems to be able to build .apk just fine, see:
https://gist.github.com/proppy/e41195a41bea12e8c205

@hyangah
Copy link
Contributor

hyangah commented Feb 10, 2015

I guess oracle jdk was chosen just because it's in the system requirement page of the android developer site https://developer.android.com/sdk/index.html#Requirements

The current way of building go mobile apps using docker image will be obsolete soon when @crawshaw 's gomobile tool becomes ready. #9508.

https://docs.google.com/document/d/1cePOQ35PNEb_QqxnPAmBv0cEnAm7AQSGuz9wVeJ-lBs/edit?disco=AAAAAT-St2U

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title mobile: use java:openjdk docker base image x/mobile: use java:openjdk docker base image Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-mobile label Apr 14, 2015
@gopherbot
Copy link

CL https://golang.org/cl/12126 mentions this issue.

@golang golang locked and limited conversation to collaborators Jul 13, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
No longer necessary now we have the gomobile tool.

Fixes golang/go#10522.
Fixes golang/go#9823.

Change-Id: I21a793507cfd4d72c37a9e5c9f2d16d9b5622bd2
Reviewed-on: https://go-review.googlesource.com/12126
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 11, 2021
No longer necessary now we have the gomobile tool.

Fixes golang/go#10522.
Fixes golang/go#9823.

Change-Id: I21a793507cfd4d72c37a9e5c9f2d16d9b5622bd2
Reviewed-on: https://go-review.googlesource.com/12126
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants