sort: the Sort function doesn't exit early for short inputs #9793
Labels
Comments
|
It doesn't look like it ends up allocating any memory or doing any work, at least at tip. Sort calls quickSort which checks if it has over 7 elements and does quick sort if so (but not for short inputs), then checks if it has over 1 element and does insertion sort (but not for short inputs). So looks like this is already done. I'm close this bug, but feel free to point out that I'm wrong if I'm misreading it. |
|
You're right. I had an error in my testing code. Sorry for the confusion. Aaron On 2/6/15, Brad Fitzpatrick notifications@github.com wrote:
|
mikioh
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
In func Sort(data Interface), we already call data.Len(). However we don't check to see if it returned a value < 2. We should, and if so, return immediately. As it is now, without this simple check, we end up allocating memory, regardless of whether or not we can do anything with the item passed.
Adding this check should have an insignificant impact on other calls to this function, since we're just doing a simple test on a variable we already have.
The text was updated successfully, but these errors were encountered: