Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/webdav: TestDir fails on windows #9786

Closed
alexbrainman opened this issue Feb 6, 2015 · 2 comments
Closed

x/net/webdav: TestDir fails on windows #9786

alexbrainman opened this issue Feb 6, 2015 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@alexbrainman
Copy link
Member

C:>go test golang.org/x/net/webdav
--- FAIL: TestDir (0.00s)
file_test.go:506: test case #65 "rename /c /d/n/q want ok": got "errExist" (rename C:\DOCUME1\brainman\LOCALS1\Temp\webdav-test593615143\c C:\DOCUME1\brainman\LOCALS1\Temp\webdav-test593615143\d\n\q: Cannot create a file when that file already exists.), want "ok"
FAIL
FAIL golang.org/x/net/webdav 0.547s

This is broken on windows builders too.

Alex
@alexbrainman
Copy link
Member Author

Proposed fix is here https://go-review.googlesource.com/4020

Alex

@nigeltao
Copy link
Contributor

Counter-proposal: https://go-review.googlesource.com/4341

@mikioh mikioh changed the title webdav: TestDir fails on windows x/net/webdav: TestDir fails on windows Jul 30, 2015
@mikioh mikioh modified the milestone: Unreleased Jul 30, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
dt-eric-lefevreardant pushed a commit to DiliTrust/go-webdav that referenced this issue Mar 11, 2025
@nigeltao
webdav: factor out a moveFiles function, and make the tests call that
bd2e9f2 
instead of FileSystem.Rename directly.

Dir.Rename's behavior wrt overwriting existing files and directories is
OS-dependent.

Fixes golang/go#9786

Change-Id: If42728caa6f0f38f8e3d6b1fcdda8c2d272080d6
Reviewed-on: https://go-review.googlesource.com/4341
Reviewed-by: Nick Cooper <nmvc@google.com>
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mikioh @nigeltao @gopherbot @alexbrainman