Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: nacl-amd64p32 build broken #9760

Closed
bradfitz opened this issue Feb 3, 2015 · 1 comment
Closed

runtime: nacl-amd64p32 build broken #9760

bradfitz opened this issue Feb 3, 2015 · 1 comment
Milestone

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Feb 3, 2015

nacl-amd64p32 is broken by the frame pointer change.

3c0fee1 broke nacl-amd64p32:

http://build.golang.org/log/e1140e7109fb8524065c1a90e0f933c9ffd5d48d


##### Testing packages.
runtime: found space for saved base pointer, but no framepointer experimentfatal error: bad frame layout

runtime stack:
runtime.throw(0x2cb9e8, 0x10)
    /nacl-amd64p32-3c0fee10dbe8/go/src/runtime/panic.go:511 +0x160
runtime.adjustframe(0xfffefd80, 0xfffefdf4, 0x66f301, 0x5386)
    /nacl-amd64p32-3c0fee10dbe8/go/src/runtime/stack1.go:472 +0x2c0
runtime.gentraceback(0x391c0, 0x10916778, 0x0, 0x109000a0, 0x0, 0x0, 0x7fffffff, 0x310eb4, 0xfffefdf4, 0x0, ...)
    /nacl-amd64p32-3c0fee10dbe8/go/src/runtime/traceback.go:288 +0xb20
runtime.copystack(0x109000a0, 0x1000)
    /nacl-amd64p32-3c0fee10dbe8/go/src/runtime/stack1.go:569 +0x1e0
runtime.newstack()
    /nacl-amd64p32-3c0fee10dbe8/go/src/runtime/stack1.go:757 +0x13a0
runtime.morestack()
    /nacl-amd64p32-3c0fee10dbe8/go/src/runtime/asm_amd64p32.s:283 +0xa0

....
@bradfitz bradfitz added this to the Go1.5 milestone Feb 3, 2015
@aclements
Copy link
Member

Found the problem. I used ptrSize instead of regSize in a key place.

@mikioh mikioh changed the title nacl-amd64p32 build broken runtime: nacl-amd64p32 build broken Feb 3, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants