-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: race builder mixes benchmark and test failure output #9717
Comments
What exactly is a mess? |
I think Brad just complains about the fact that if the race build breaks, |
Hey, it is a punishment for anybody who introduces a data race. Speaking seriously, ^F "data race" always worked for me. |
Right. It's easy if you know what you're looking for. But looking at the output of other builders doesn't require |
Here's an example of garble: https://storage.googleapis.com/go-build-log/df6b9696/linux-amd64-race_b0f4624a.log
What is happening there? |
^F "fail" is my second secret |
I don't see what this has to do with cmd/gc. |
Sorry, the title meant to be cmd/go (or maybe testing:) |
I'll fix this for free when the builders do test sharding probably. |
Closing for now. I think this is fixed, or at least works totally differently from 2015. |
The output of race.bash is a mess. e.g.:
http://build.golang.org/log/0a062dae109415840b118fbc4189c83e7b5c068a
It's hard to see anything.
We plan to rewrite run.bash into Go. It's probably time that race.bash is also rewritten in Go, so it can capture the output of child processes and not interleave them all.
Dmitry, can you fix?
The text was updated successfully, but these errors were encountered: