-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime/pprof: does StartTrace belong? #9710
Comments
"runtime/trace" trace.Start ? On 29 January 2015 at 02:59, Russ Cox notifications@github.com wrote:
|
I did it looking at CPU profiling support which is essentially the same. The design doc also mentions functions that allow to emit user marks into the trace to denote scopes of something or just one-off events (a-la TraceEvent, TraceScopeBegin, TraceScopeEnd). I've already seen two inquiries about this on golang-nuts. So StartTrace/EndTrace + TraceEvent/TraceScopeBegin/TraceScopeEnd can make a case for runtime/trace package. |
Hi Russ, We need to decide on this asap. People continue to ask about user-emitted events in traces. Some people also proposed some options for tracing, like disable stack collection. |
https://golang.org/cl/8552 does not mention this issue but should. |
Humm... I can't change that change anymore:
|
@dvyukov try running |
I've mailed a new change https://go-review.googlesource.com/#/c/12511/ that just moves StartTrace/StopTrace to the new package. |
CL https://golang.org/cl/12511 mentions this issue. |
Dmitriy's new tracing has API entry points in runtime/pprof because all the other runtime tracing does. But it's not consumed by pprof and probably belongs somewhere else. Decide.
The text was updated successfully, but these errors were encountered: