Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: suggest add default ReadTimeout and WriteTimeout to Server #9688

Closed
haosdent opened this issue Jan 26, 2015 · 1 comment
Closed

net/http: suggest add default ReadTimeout and WriteTimeout to Server #9688

haosdent opened this issue Jan 26, 2015 · 1 comment
Labels
FrozenDueToAge

Comments

@haosdent
Copy link
Contributor

I think default ReadTimeout and WriteTimeout are necessary. Because when server without timeout, a lot of idle connection form client are use up the memory and sockets of memory. It is easy to use by cracker.
@minux
Copy link
Member

minux commented Jan 26, 2015

Are you suggesting that when Server.{Read,Write}Timeout is zero,
we apply some default settings?

What if the user really don't want Read/WriteTimeout? I think this will
be an API change and against the Go 1 API stability guarantee.

@minux minux closed this as completed Jan 26, 2015
@mikioh mikioh changed the title suggest add default ReadTimeout and WriteTimeout to net/http/#Server net/http: suggest add default ReadTimeout and WriteTimeout to Server Jan 26, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@minux @haosdent @gopherbot