log: Output() does not append a newline if the string is empty #9665

nerdatmath · 2015-01-22T16:56:51Z

Go version: 1.3 and up to current tip

Running the following program results in a single output line with two log headers (http://play.golang.org/p/e0CHv4tdQi):

package main
import "log"
func main() {
    log.Print("")
    log.Println("<- two headers")
}

I believe this line in log/log.go (Logger.Output):

     if len(s) > 0 && s[len(s)-1] != '\n' {

Should be changed to read:

     if len(s) == 0 || s[len(s)-1] != '\n' {

Thank you for your consideration.

bradfitz added this to the Go1.5 milestone Jan 22, 2015

bradfitz assigned robpike Jan 22, 2015

robpike closed this as completed in d340b10 Apr 9, 2015

golang locked and limited conversation to collaborators Jun 25, 2016

gopherbot added the FrozenDueToAge label Jun 25, 2016

rsc unassigned robpike Jun 23, 2022

Provide feedback