bytes: bytes.Count(buf, []byte {}) return number of runes in buf + 1 #9659

kostya-sh · 2015-01-22T06:27:19Z

I believe bytes.Count(buf, []byte {}) should return len(buf) + 1. Currently it returns utf8.RuneCount(s) + 1

Demo to show the problem: http://play.golang.org/p/xjQJGlmuOJ

The text was updated successfully, but these errors were encountered:

bradfitz · 2015-01-22T06:31:41Z

Either way, the docs don't say. And I agree the name of the package alone would suggest it operates on bytes and not runes. Over to @robpike.

minux · 2015-01-22T06:39:07Z

The reason is that bytes.Count is direct analogous to the strings.Count
function.

However, I do agree that although this behavior is natural for
strings.Count,
it is not apparent for bytes.Count.

Needs doc fix.

cespare · 2015-01-22T06:42:27Z

We had the same discussion on #8143 (about Replace). bytes is intended to be the same as strings, but just take []byte arguments.

kostya-sh changed the title ~~bytes.Count(buf, []byte {}) return number of runes in buf + 1~~ bytes: bytes.Count(buf, []byte {}) return number of runes in buf + 1 Jan 22, 2015

bradfitz assigned robpike Jan 22, 2015

bradfitz added this to the Go1.5 milestone Jan 22, 2015

griesemer closed this as completed in 19c1b16 Jan 22, 2015

golang locked and limited conversation to collaborators Jun 25, 2016

gopherbot added the FrozenDueToAge label Jun 25, 2016

rsc unassigned robpike Jun 23, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bytes: bytes.Count(buf, []byte {}) return number of runes in buf + 1 #9659

bytes: bytes.Count(buf, []byte {}) return number of runes in buf + 1 #9659

kostya-sh commented Jan 22, 2015

bradfitz commented Jan 22, 2015

minux commented Jan 22, 2015

cespare commented Jan 22, 2015

bytes: bytes.Count(buf, []byte {}) return number of runes in buf + 1 #9659

bytes: bytes.Count(buf, []byte {}) return number of runes in buf + 1 #9659

Comments

kostya-sh commented Jan 22, 2015

bradfitz commented Jan 22, 2015

minux commented Jan 22, 2015

cespare commented Jan 22, 2015