Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/pack: freebsd-amd64-race failure in TestLargeDefs #9656

Closed
bradfitz opened this issue Jan 22, 2015 · 4 comments
Closed

cmd/pack: freebsd-amd64-race failure in TestLargeDefs #9656

bradfitz opened this issue Jan 22, 2015 · 4 comments

Comments

@bradfitz
Copy link
Contributor

freebsd-amd64-race are all failing with:

--- FAIL: TestLargeDefs (112.46s)
    pack_test.go:313: [go tool 6g large.go]: exit status 1
        6g: running /tmp/buildlet-scatch008670939/go/pkg/tool/freebsd_amd64/objwriter: unsuccessful exit status 0x9
FAIL
FAIL    cmd/pack    115.819s

Does that mean anything to anybody?

Real race in there? We should capture the stdout/stderr of that child and include it in the error message there.

/cc @rsc @dvyukov

@bradfitz
Copy link
Contributor Author

Well, some succeed.

It's worth nothing that these are all run in their own fresh & dedicated n1-highcpu-4 VM: 4 virtual CPUs (2 real cores) and 3.60 GB of RAM. So it shouldn't be a flaky machine issue.

@bradfitz
Copy link
Contributor Author

Oh, I see some Solaris failures as well:

--- FAIL: TestLargeDefs (12.98s)
    pack_test.go:313: [go tool 6g large.go]: exit status 1
        6g: running /root/work/solaris-amd64-smartos-ebaf8db4f62a/go/pkg/tool/solaris_amd64/objwriter: Not enough space
FAIL
FAIL    cmd/pack    16.452s

Maybe it just writes too much to disk and the builders don't have enough space?

@minux
Copy link
Member

minux commented Jan 22, 2015

I'm pretty sure it's due to space issues.

cmd/pack test generates a 6,988,923-byte large.go, the intermediate
goliblink.in file is 104,534,157 bytes, and the final .6 file has 16,812,010
bytes.

@bradfitz
Copy link
Contributor Author

bradfitz added a commit that referenced this issue Feb 4, 2015
Fixes #9656

Change-Id: I1158636683492ef12eeafb12e257d205026adc3f
Reviewed-on: https://go-review.googlesource.com/3175
Reviewed-by: Minux Ma <minux@golang.org>
Reviewed-on: https://go-review.googlesource.com/3910
Reviewed-by: Dave Cheney <dave@cheney.net>
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants