Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/review/git-codereview: 'git sync' should say what happened #9633

Open
adg opened this issue Jan 19, 2015 · 3 comments
Open

x/review/git-codereview: 'git sync' should say what happened #9633

adg opened this issue Jan 19, 2015 · 3 comments
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@adg
Copy link
Contributor

adg commented Jan 19, 2015

When git sync does a fast forward or rebase, it would be nice to know what it did.

Something like this:

$ git sync
Synced local branch 'foo' HEAD to d34db33f (17 new commits)
$ git sync
Local branch 'foo' HEAD at d34db33f (no new commits)
@dvyukov
Copy link
Member

dvyukov commented Jan 19, 2015

While we are here, please also extend help for sync.
In particular, it's unclear for me (1) whether I need to do git pull before sync, (2) whether I need to do it in master or in all change branches separately.

@bradfitz
Copy link
Contributor

If this happens, can it be opt-in only? I don't like my CLI tools speaking to me, unless they had a problem.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title git-codereview: 'git sync' should say what happened x/review/git-codereview: 'git sync' should say what happened Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-review label Apr 14, 2015
@ysmolski
Copy link
Member

ysmolski commented Mar 21, 2018

It could be git sync -v to show what happened. Sometimes I really do want to see what happened during git sync.

Upd: apologize for the noise before. git sync -v already does prints many things, so this is not an option.

@andybons andybons added NeedsFix The path to resolution is known, but the work has not been done. help wanted labels Mar 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

7 participants