Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/godoc: Malformed links in variable definition #9613

Closed
titanous opened this issue Jan 16, 2015 · 7 comments
Closed

x/tools/cmd/godoc: Malformed links in variable definition #9613

titanous opened this issue Jan 16, 2015 · 7 comments
Labels
Documentation FrozenDueToAge
Milestone
Unplanned

Comments

@titanous
Copy link
Member

The documentation for http.DefaultTransport currently looks like this:

screen shot 2015-01-16 at 1 21 10 pm

There are a bunch of things linked that should not be, including all of the field names and the Dial method.
@mikioh mikioh changed the title godoc: Malformed links in variable definition cmd/godoc: Malformed links in variable definition Jan 17, 2015
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title cmd/godoc: Malformed links in variable definition x/tools/cmd/godoc: Malformed links in variable definition Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@griesemer griesemer assigned alandonovan and unassigned griesemer Oct 19, 2016
@vbmade2000
Copy link

@alandonovan Can I take a look on this issue and create PR ? If you don't mind.

@griesemer
Copy link
Contributor

@vbmade2000 You're welcome to have a look and send a PR/review request, but you may want to keep an eye out for the pending fix for (related) issue #22803 which is in progress, which may change how this looks.

@vbmade2000
Copy link

@griesemer Sure. May be I should create PR after #22803 gets merged.

@agnivade
Copy link
Contributor

May be I should create PR after #22803 gets merged.

Yes, thanks. This most probably needs work in godoc/linkify.go. Feel free to cc me when you send the CL.

@vbmade2000
Copy link

@agnivade Sure. Thanks :)

@vbmade2000
Copy link

@titanous Can you please give more exaplanation ? I checked doc but still not clear what is the issue.

@agnivade agnivade mentioned this issue Apr 25, 2018
Closed
@agnivade
Copy link
Contributor

agnivade commented Sep 28, 2019 •
edited

Everything appears fixed except the Dial method. A better issue was filed here which clearly outlines what shows and what is expected for the Dial method. I am going to close this in favor of that.

@athomason athomason mentioned this issue Sep 28, 2019
Open
@golang golang locked and limited conversation to collaborators Sep 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
9 participants
@bradfitz @titanous @mikioh @rsc @agnivade @vbmade2000 @alandonovan @griesemer @gopherbot