Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime/pprof: build occasionally fails at TestCPUProfileMultithreaded #9605

Closed
rakyll opened this issue Jan 15, 2015 · 5 comments
Closed

runtime/pprof: build occasionally fails at TestCPUProfileMultithreaded #9605

rakyll opened this issue Jan 15, 2015 · 5 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@rakyll
Copy link
Contributor

rakyll commented Jan 15, 2015

TestCPUProfileMultithreaded occasionally fails for GOOS=android and GOARCH=arm.

834 KB/s (2368016 bytes in 2.770s)
go_android_exec: adb shell cp '/data/local/tmp/goroot/pprof.test-3947-tmp' '/data/local/tmp/goroot/pprof.test-3947'
go_android_exec: adb shell rm '/data/local/tmp/goroot/pprof.test-3947-tmp'
go_android_exec: adb shell export TMPDIR="/data/local/tmp"; export GOROOT="/data/local/tmp/goroot"; cd "$GOROOT/src/runtime/pprof"; '/data/local/tmp/goroot/pprof.test-3947' -test.short=true -test.timeout=360s; echo -n exitcode=$?
--- FAIL: TestCPUProfileMultithreaded (3.60s)
pprof_test.go:165: runtime/pprof_test.cpuHog1: 0
pprof_test.go:165: runtime/pprof_test.cpuHog2: 61
pprof_test.go:179: runtime/pprof_test.cpuHog1 has 0 samples out of 61, want at least 1, ideally 30
FAIL
@bradfitz
Copy link
Contributor

qemu, right?

@mikioh mikioh changed the title pprof: build occasionally fails at TestCPUProfileMultithreaded runtime/pprof: build occasionally fails at TestCPUProfileMultithreaded Jan 15, 2015
@rakyll
Copy link
Contributor Author

rakyll commented Jan 15, 2015

Android emulator ARM v7a. It's not exactly what the mainline qemu is.

@bradfitz
Copy link
Contributor

These tests have never run well under qemu. I'd just skip them when under this environment.

Maybe set an IN_QEMU=1 environment variable, and t.Skip based on that.

@rakyll
Copy link
Contributor Author

rakyll commented Jan 17, 2015

Mailed https://go-review.googlesource.com/#/c/3000/.

@rakyll rakyll closed this as completed in dc72db9 Jan 20, 2015
@saljam saljam mentioned this issue Mar 1, 2015
Closed
@4ad
Copy link
Member

4ad commented Apr 16, 2015

This test is extremely flaky even on real arm64 hardware running Linux.

@mikioh mikioh added this to the Go1.5 milestone Apr 17, 2015
@hyangah hyangah mentioned this issue Apr 21, 2015
Closed
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
5 participants
@bradfitz @mikioh @rakyll @4ad @gopherbot