Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync/atomic: LoadPointer is missing for linux-amd64-race #9516

Closed
bradfitz opened this issue Jan 6, 2015 · 3 comments
Closed

sync/atomic: LoadPointer is missing for linux-amd64-race #9516

bradfitz opened this issue Jan 6, 2015 · 3 comments
Labels
FrozenDueToAge

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Jan 6, 2015

Commit 7b4df8f broke the linux-amd64-race builder:

sync/atomic.(*Value).Load: call to external function sync/atomic.LoadPointer
sync/atomic.(*Value).Load: sync/atomic.LoadPointer: not defined
sync/atomic.(*Value).Load: sync/atomic.LoadPointer: not defined
sync/atomic.(*Value).Store: sync/atomic.LoadPointer: not defined
sync/atomic_test.TestLoadPointer: sync/atomic.LoadPointer: not defined
sync/atomic_test.hammerStoreLoadPointer: sync/atomic.LoadPointer: not defined
sync/atomic_test.func·038: sync/atomic.LoadPointer: not defined
sync/atomic.(*Value).Load: undefined: sync/atomic.LoadPointer
sync/atomic.(*Value).Load: undefined: sync/atomic.LoadPointer
sync/atomic.(*Value).Store: undefined: sync/atomic.LoadPointer
sync/atomic_test.TestLoadPointer: undefined: sync/atomic.LoadPointer
sync/atomic_test.hammerStoreLoadPointer: undefined: sync/atomic.LoadPointer
sync/atomic_test.func·038: undefined: sync/atomic.LoadPointer

/cc @dvyukov @rsc @minux
@cookieo9
Copy link
Contributor

cookieo9 commented Jan 7, 2015

Windows/amd64 is also broken.

@minux
Copy link
Member

minux commented Jan 7, 2015

Sent https://go-review.googlesource.com/2401.

./race.bash still has two failing tests after fixing the build,
but I think that's a separate issue.

minux added a commit that referenced this issue Jan 7, 2015
@minux
runtime: fix build for race detector
5f179c7 
This CL only fixes the build, there are two failing tests:
RaceMapBigValAccess1 and RaceMapBigValAccess2
in runtime/race tests. I haven't investigated why yet.

Updates #9516.

Change-Id: If5bd2f0bee1ee45b1977990ab71e2917aada505f
Reviewed-on: https://go-review.googlesource.com/2401
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@bradfitz
Copy link
Contributor Author

Fixed by 5f179c7

@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bradfitz @cookieo9 @minux @gopherbot