Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile: gobind tests leaking temporary files on the builder #9513

Closed
minux opened this issue Jan 6, 2015 · 2 comments
Closed

x/mobile: gobind tests leaking temporary files on the builder #9513

minux opened this issue Jan 6, 2015 · 2 comments
Milestone

Comments

@minux
Copy link
Member

minux commented Jan 6, 2015

I found a lot of files in the builder's /tmp directory of this form:
goXXXXX and javaXXXXX.

The content of these files showed that they are temporary files for the gobind tests:

// Package go_basictypes is an autogenerated binder stub for package basictypes.
//   gobind -lang=go basictypes
//
// File is generated by gobind. Do not edit.
package go_basictypes

import (
        "basictypes"
        "golang.org/x/mobile/bind/seq"
)

func proxy_ByteArrays(out, in *seq.Buffer) {
        param_x := in.ReadByteArray()
        res := basictypes.ByteArrays(param_x)
        out.WriteByteArray(res)
}
// snip

And

// Java Package interfaces is a proxy for talking to a Go program.
//   gobind -lang=java interfaces
//
// File is generated by gobind. Do not edit.
package go.interfaces;

import go.Seq;

public abstract class Interfaces {
    private Interfaces() {} // uninstantiable
// snip

Perhaps this the reason why some builders' file system has been filled.

PS: I just cleaned up the /tmp yesterday, and now it has accumulated about 200 of these
files, so I'm certain this bug is still there.

@minux minux added this to the Go1.5 milestone Jan 6, 2015
@alexbrainman
Copy link
Member

review tests were leaving behind garbage in %TEMP% directory on windows too. I have fixed that in https://go-review.googlesource.com/#/c/2089/

@bradfitz, perhaps you can remove these on our windows builder too. Thank you.

Alex

@minux
Copy link
Member Author

minux commented Jan 6, 2015

Turns out to be easy to fix, sent https://golang.org/cl/2343

@mikioh mikioh changed the title mobile: gobind tests leaking temporary files on the builder x/mobile: gobind tests leaking temporary files on the builder Aug 5, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
Fixes golang/go#9513

Change-Id: I19a14f6e8f24396e5a191258917e5ff9caf8928a
Reviewed-on: https://go-review.googlesource.com/2343
Reviewed-by: Andrew Gerrand <adg@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants