Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/ssh: Support chacha20-poly1305@openssh.com authenticated encryption cipher #9489

Closed
christophershirk opened this issue Jan 2, 2015 · 9 comments
Closed

x/crypto/ssh: Support chacha20-poly1305@openssh.com authenticated encryption cipher #9489

christophershirk opened this issue Jan 2, 2015 · 9 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@christophershirk
Copy link

It would be useful if the x/crypto/ssh package implemented @djmdjm 's chacha20-poly1305@openssh.com authenticated encryption cipher.

More info
@titanous
Copy link
Member

titanous commented Jan 2, 2015

Here's an initial mailing list thread about this: https://groups.google.com/forum/#!topic/golang-dev/4ucY4qLCy2I

@codahale has a ChaCha20 implementation that we might be able to upstream, I'm not sure what the status of the CL is: https://go-review.googlesource.com/#/c/1363/

@minux
Copy link
Member

minux commented Jan 2, 2015

CL 1363 is abandoned.
I will send a CL to add chacha20 package with minimal API suitable
for both TLS and OpenSSH to x/crypto.

@mikioh mikioh changed the title x/crypto/ssh: Support chacha20-poly1305@openssh.com authenticated encryption cipher ssh: Support chacha20-poly1305@openssh.com authenticated encryption cipher Jan 4, 2015
@generalmanager generalmanager mentioned this issue Feb 27, 2015
Closed
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title ssh: Support chacha20-poly1305@openssh.com authenticated encryption cipher x/crypto/ssh: Support chacha20-poly1305@openssh.com authenticated encryption cipher Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-crypto label Apr 14, 2015
@hanwen
Copy link
Contributor

hanwen commented Aug 12, 2015

@minux - any update on chacha20 ?

@funny-falcon
Copy link
Contributor

chacha20-poly1305 will be useful for https too, cause Android mobile browsers prefers this cipher.

@funny-falcon
Copy link
Contributor

also, it is faster on processors without aes support.
For example, even on servers with Xeon which supports aes-enc, it could be disabled by mother board manufacturer.

@Thomasdezeeuw Thomasdezeeuw mentioned this issue Jun 24, 2016
Closed
@hanwen
Copy link
Contributor

hanwen commented Jan 9, 2017

as of

commit 594708b
Author: Adam Langley agl@golang.org
Date: Mon Oct 10 14:34:47 2016 -0700

chacha20 / poly1305 is in x/crypto, so this could be considered.

@mark-adams
Copy link
Contributor

I almost have a working implementation of this and should have a change submitted soon.

@hanwen
Copy link
Contributor

hanwen commented Jan 10, 2018

see https://go-review.googlesource.com/c/crypto/+/87077

@gopherbot
Copy link

Change https://golang.org/cl/87077 mentions this issue: ssh: support chacha20-poly1305 cipher.

@golang golang locked and limited conversation to collaborators Jan 19, 2019
bored-engineer pushed a commit to bored-engineer/ssh that referenced this issue Oct 13, 2019
@hanwen
ssh: support chacha20-poly1305 cipher
280a7c1 
chacha20-poly1305 is an AEAD which performs well without hardware
support. It is recommended as a replacement for the aging arcfour128
and arcfour256 ciphers.

Fixes golang/go#9489

Change-Id: I5d5a4620a435e65997f0ba7e683a34c29d9a396b
Reviewed-on: https://go-review.googlesource.com/87077
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
bored-engineer pushed a commit to bored-engineer/ssh that referenced this issue Oct 13, 2019
@hanwen
ssh: support chacha20-poly1305 cipher
53fdca1 
chacha20-poly1305 is an AEAD which performs well without hardware
support. It is recommended as a replacement for the aging arcfour128
and arcfour256 ciphers.

Fixes golang/go#9489

Change-Id: I5d5a4620a435e65997f0ba7e683a34c29d9a396b
Reviewed-on: https://go-review.googlesource.com/87077
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
bored-engineer pushed a commit to bored-engineer/ssh that referenced this issue Oct 13, 2019
@hanwen
ssh: support chacha20-poly1305 cipher
77fb4b4 
chacha20-poly1305 is an AEAD which performs well without hardware
support. It is recommended as a replacement for the aging arcfour128
and arcfour256 ciphers.

Fixes golang/go#9489

Change-Id: I5d5a4620a435e65997f0ba7e683a34c29d9a396b
Reviewed-on: https://go-review.googlesource.com/87077
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 28, 2022
@hanwen
ssh: support chacha20-poly1305 cipher
e76aadc 
chacha20-poly1305 is an AEAD which performs well without hardware
support. It is recommended as a replacement for the aging arcfour128
and arcfour256 ciphers.

Fixes golang/go#9489

Change-Id: I5d5a4620a435e65997f0ba7e683a34c29d9a396b
Reviewed-on: https://go-review.googlesource.com/87077
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
c-expert-zigbee pushed a commit to c-expert-zigbee/crypto_go that referenced this issue Mar 29, 2022
@hanwen
ssh: support chacha20-poly1305 cipher
4c12a54 
chacha20-poly1305 is an AEAD which performs well without hardware
support. It is recommended as a replacement for the aging arcfour128
and arcfour256 ciphers.

Fixes golang/go#9489

Change-Id: I5d5a4620a435e65997f0ba7e683a34c29d9a396b
Reviewed-on: https://go-review.googlesource.com/87077
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
LewiGoddard pushed a commit to LewiGoddard/crypto that referenced this issue Feb 16, 2023
@hanwen
ssh: support chacha20-poly1305 cipher
791f12d 
chacha20-poly1305 is an AEAD which performs well without hardware
support. It is recommended as a replacement for the aging arcfour128
and arcfour256 ciphers.

Fixes golang/go#9489

Change-Id: I5d5a4620a435e65997f0ba7e683a34c29d9a396b
Reviewed-on: https://go-review.googlesource.com/87077
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
BiiChris pushed a commit to BiiChris/crypto that referenced this issue Sep 15, 2023
@hanwen
ssh: support chacha20-poly1305 cipher
92ec4b8 
chacha20-poly1305 is an AEAD which performs well without hardware
support. It is recommended as a replacement for the aging arcfour128
and arcfour256 ciphers.

Fixes golang/go#9489

Change-Id: I5d5a4620a435e65997f0ba7e683a34c29d9a396b
Reviewed-on: https://go-review.googlesource.com/87077
Run-TryBot: Han-Wen Nienhuys <hanwen@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Adam Langley <agl@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
8 participants
@titanous @hanwen @rsc @minux @funny-falcon @mark-adams @christophershirk @gopherbot