Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/icmp: Marshal and Parse make wrong ICMPv4 parameter problem message #9394

Closed
mikioh opened this issue Dec 19, 2014 · 1 comment
Closed

x/net/icmp: Marshal and Parse make wrong ICMPv4 parameter problem message #9394

mikioh opened this issue Dec 19, 2014 · 1 comment
Labels
FrozenDueToAge

Comments

@mikioh
Copy link
Contributor

mikioh commented Dec 19, 2014

https://tools.ietf.org/html/rfc792 says that "Pointer field: If code = 0, identifies the octet where an error was detected." It's an octet field, unlike ICMPv6, ouch.
@mikioh mikioh self-assigned this Dec 19, 2014
@mikioh mikioh added repo-net and removed repo-net labels Dec 23, 2014
@mikioh
Copy link
Contributor Author

mikioh commented Jan 1, 2015

Closed by https://go-review.googlesource.com/#/c/2083/

@mikioh mikioh closed this as completed Jan 1, 2015
@mikioh mikioh changed the title x/net/icmp: Marshal and Parse make wrong ICMPv4 parameter problem message icmp: Marshal and Parse make wrong ICMPv4 parameter problem message Jan 4, 2015
@mikioh mikioh removed their assignment May 27, 2015
@mikioh mikioh changed the title icmp: Marshal and Parse make wrong ICMPv4 parameter problem message x/net/icmp: Marshal and Parse make wrong ICMPv4 parameter problem message Jul 20, 2015
@golang golang locked and limited conversation to collaborators Jul 20, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikioh @gopherbot