Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: commit-msg hook doesn't play well with Signed-off-by lines #9385

Open
minux opened this issue Dec 18, 2014 · 1 comment
Open

x/review/git-codereview: commit-msg hook doesn't play well with Signed-off-by lines #9385

minux opened this issue Dec 18, 2014 · 1 comment
Milestone
Unreleased

Comments

@minux
Copy link
Member

minux commented Dec 18, 2014

For example, git commit -s will generate this log message:

    test: test commit

    Signed-off-by: Shenghou Ma <minux@golang.org>

    Change-Id: I3545610fc076ab9da46bb5ed571a49730a5075dc

However, it should look this instead, which is generated by the official gerrit commit-msg hook:

    test: test commit

    Change-Id: I3545610fc076ab9da46bb5ed571a49730a5075dc    
    Signed-off-by: Shenghou Ma <minux@golang.org>
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title review: commit-msg hook doesn't play well with Signed-off-by lines x/review: commit-msg hook doesn't play well with Signed-off-by lines Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-review label Apr 14, 2015
@mikioh mikioh changed the title x/review: commit-msg hook doesn't play well with Signed-off-by lines x/review/git-codereview: commit-msg hook doesn't play well with Signed-off-by lines Aug 17, 2015
@r5d
Copy link
Contributor

r5d commented Jan 9, 2022

I think this is address in golang/review@2e4fd9a

Close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@rsc @minux @r5d