Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/review/git-codereview: TestCurrentBranch fails #9379

Closed
josharian opened this issue Dec 18, 2014 · 13 comments
Closed

x/review/git-codereview: TestCurrentBranch fails #9379

josharian opened this issue Dec 18, 2014 · 13 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@josharian
Copy link
Contributor 

--- FAIL: TestCurrentBranch (0.17s)
    branch_test.go:13: on master
    branch_test.go:16: on newbranch
    branch_test.go:45: b.OriginBranch() = "master", want "origin/master"
    branch_test.go:20: making change
    branch_test.go:45: b.OriginBranch() = "master", want "origin/master"
    branch_test.go:25: on dev.branch
    branch_test.go:29: on newdev
    branch_test.go:33: making change

Reproduced with both git 1.8.5.3 and 2.2.0 on OS X. But build.golang.org says the review subrepo is passing, and no one else seems to have noticed.

I think that the failure is legit. I'll send a fix in a bit.
@josharian josharian self-assigned this Dec 18, 2014
@josharian
Copy link
Contributor Author

Mailed https://go-review.googlesource.com/1772.

@adg any insight into why build.golang.org is happy despite the test failure?

@josharian
Copy link
Contributor Author

Fixed by golang/review@63cbb9c. Not sure why codereview didn't fix the "Fixes" reference for me.

@mattn
Copy link
Member

mattn commented Dec 18, 2014

because repository is not golang/go. it's golang/review.

@paranoiacblack
Copy link
Contributor

There is no commit-msg-hook that currently does this. See #9273.

@josharian
Copy link
Contributor Author

Ah, thanks @paranoiacblack. I knew I saw something about that go through.

@mattn
Copy link
Member

mattn commented Dec 18, 2014

AFAIK, it's not possible to close the issue on golang/go via commit message on golang/review eventhough you put something into commit-msg-hook.

@titanous
Copy link
Member

@mattn Writing Closes golang/go#123 in a commit message should work.

@paranoiacblack
Copy link
Contributor

@mattn, see https://help.github.com/articles/closing-issues-via-commit-messages/#closing-an-issue-in-a-different-repository.

Look through some of the other issues filed against review, tools, etc. They are usually closed in this way.

@mattn
Copy link
Member

mattn commented Dec 18, 2014

Wow, I didn't know. Thanks!

@josharian
Copy link
Contributor Author

Fix reverted per @rsc. Leaving for @rsc to re-fix as he sees fit.

@josharian josharian reopened this Dec 18, 2014
@josharian josharian assigned rsc and unassigned josharian Dec 18, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title git-codereview: TestCurrentBranch fails x/review/git-codereview: TestCurrentBranch fails Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-review label Apr 14, 2015
@rsc
Copy link
Contributor

rsc commented Jan 29, 2016

Can't reproduce this.

@rsc rsc closed this as completed Jan 29, 2016
@josharian
Copy link
Contributor Author

This still reproduces for me, now at git version 2.8.3. I'm going to send a CL commenting out the tests until we can figure out what the right fix is, because it's frustrating working on code with failing tests.

@josharian josharian reopened this Jun 10, 2016
@gopherbot
Copy link

CL https://golang.org/cl/23969 mentions this issue.

@golang golang locked and limited conversation to collaborators Jun 14, 2017
AndersonQ pushed a commit to AndersonQ/go that referenced this issue Oct 12, 2019
@josharian
git-codereview: fix TestCurrentBranch
63cbb9c 
Fixes golang#9379

Change-Id: Ia9122464574355c01e6c457087b0eef9375826e2
Reviewed-on: https://go-review.googlesource.com/1772
Reviewed-by: Chris Manghane <cmang@golang.org>
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
6 participants
@mattn @titanous @josharian @rsc @paranoiacblack @gopherbot