Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/tls: implement FALLBACK_SCSV #9363

Closed
bradfitz opened this issue Dec 17, 2014 · 4 comments
Closed

crypto/tls: implement FALLBACK_SCSV #9363

bradfitz opened this issue Dec 17, 2014 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@bradfitz
Copy link
Contributor

Per @agl, Go 1.5 should have FALLBACK_SCSV support.
@bradfitz bradfitz added this to the Go1.5 milestone Dec 17, 2014
@titanous
Copy link
Member

Specifically, support in the TLS client. The server got support in e5624ed.

@titanous
Copy link
Member

Hmm, now I'm confused. From the release notes:

(The Go client does not support fallback at all, so it is not vulnerable to those attacks.)

@agl
Copy link
Contributor

agl commented Dec 17, 2014

Hey cool, it looks like I landed this in 1.4 in the form of e5624ed so it's already done.

@agl agl closed this as completed Dec 17, 2014
@bgentry
Copy link
Contributor

bgentry commented Dec 18, 2014

on a related note, a bug that broke TLS_FALLBACK_SCSV out-of-the-box was fixed today: https://go-review.googlesource.com/#/c/1776/

In order to make this work on 1.4, you need to specify a MaxVersion in your tls.Config.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
5 participants
@bradfitz @titanous @agl @bgentry @gopherbot