-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/go: invoke git without terminal, so it cannot ask for password #9341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This is GitHub misbehaving. They don't want to aid discovery of private repos, so they return auth challenges instead of a 404. Not sure of the best move here. |
I think we want to permit people to use "go get" with private repositories, where they authenticate themselves at "go get" time, so I don't see how we can do anything to make this better. |
Maybe there's something we can tell git when we invoke it so that it doesn't prompt for interactive auth. But that may defy user expectations also. :-/ |
The options seem to be:
I'm okay with 2. What do other people think? |
I'm ok with 2, as long it doesn't make the |
2 seems fine. I know we support older versions of git, but git 2.3.0 introduced the |
@josharian git on Windows is stil on version 1.9.5 so please support lower git versions in the fix :) |
Thanks Josh. I will use that suggestion. @Thomasdezeeuw, I'm sorry, but I have no idea how to fix |
CL https://golang.org/cl/12175 mentions this issue. |
Wild guess: setting http://godoc.org/syscall#SysProcAttr.Noctty to true, doesn't help? |
Maybe add info to the docs and a link to this issue, since Git for Windows is still at 1.9.5 (https://git-scm.com/download/win, it autostarts a download)? |
This might be helpful. Code that's started using GIT_TERMINAL_PROMPT had other workarounds before, e.g. vim-plug took |
When doing
go get ...
if the repository has been renamed/deleted by the owner, the go get progress will stuck and asking for Username and Password (especially ongithub
). It would be nice if404
errors from repository would makego get
skip current repository instead of asking username and password.The text was updated successfully, but these errors were encountered: