-
Notifications
You must be signed in to change notification settings - Fork 18k
cmd/dist: wrong version computed #9296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
the problem is not cmd/dist's. The builder will generate a VERSION file Now that we switched to git, we don't need that speed hack anymore. |
Do we still need to support hg in tools/dashboard/builder? If not, we can My last comment had a typo, it should be "hg archive" not "hg export". |
We can drop hg support. |
OK. I will do some test on the netbsd-386 builder. @bradfitz, could you clear the result for netbsd-386-minux builder |
We don't have an easy+safe way to clear a result or row or column from the dashboard yet. We should have such a mechanism. Before we have a tool, I'm reluctant to touch anything by hand. |
My changes are working now. However it seems Gerrit has disabled upload from unregistered users. Here is the patch: https://gist.github.com/minux/c2b1c270ac1c7ea1a0cc |
Gerrit has never allowed unauthenticated uploads. What do you mean? But I don't think your patch is quite what we want. We still want to re-use the git repo $GOROOT we place at /goroot in the Linux docker images as a base, and only git pull up from that to our target build hash. I fear that your patch will cause way too many git clone operations, which weigh in at 50+ MB each, and lots of disk I/O. |
This is the error I was getting: I also tried to create a change on the web interface, but I got the same My patch doesn't change how the git repository is handled. The current |
Oh, I see we've disabled people without +2 from pushing changes, until we fix some Gerrit configuration things about the CLA checks. |
@minux, you should be able to upload again. |
Thanks very much, @bradfitz, I've mailed golang.org/cl/1510 |
I did intend for the cmd/dist/build.c change to yield "devel ", but @rsc was getting me to make a bunch of changes during its review and I think it slipped aside in the process. I can look into fixing that tomorrow if no-one has already started. |
I went to start fixing
So |
The builder will no longer generate a VERSION file, so we can revert https://golang.org/cl/1405 once all builders have updated. Fixes golang/go#9296. Change-Id: Ie51cb06a712157c16b231167f166b31d10ba8667 Signed-off-by: Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/1510 Reviewed-by: Andrew Gerrand <adg@golang.org> Reviewed-by: Chris Manghane <cmang@golang.org>
The builder will no longer generate a VERSION file, so we can revert https://golang.org/cl/1405 once all builders have updated. Fixes golang/go#9296. Change-Id: Ie51cb06a712157c16b231167f166b31d10ba8667 Signed-off-by: Shenghou Ma <minux@golang.org> Reviewed-on: https://go-review.googlesource.com/1510 Reviewed-by: Andrew Gerrand <adg@golang.org> Reviewed-by: Chris Manghane <cmang@golang.org>
This reverts commit 11d1c05. See #9296 for details. Change-Id: I89a36351cb007836662f28a611af5616818b95fe Reviewed-on: https://go-review.googlesource.com/1536 Reviewed-by: Minux Ma <minux@golang.org> Reviewed-by: Russ Cox <rsc@golang.org> Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
https://go-review.googlesource.com/#/c/1405/2 fixed cmd/api to put up with a runtime.Version() that doesn't begin with 'devel' but is a development branch (not a release-branch). That should never happen. cmd/dist should be fixed not to do that, and the CL should be rolled back so that cmd/api is not tolerating the bug.
@bradfitz @dsymonds
The text was updated successfully, but these errors were encountered: