Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hash: are you accepting new hash algorithms? #9295

Closed
OneOfOne opened this issue Dec 12, 2014 · 2 comments
Closed

hash: are you accepting new hash algorithms? #9295

OneOfOne opened this issue Dec 12, 2014 · 2 comments

Comments

@OneOfOne
Copy link
Contributor

Are there any plans to include new hash algorithms?

Mainly xxhash, I have an implementation @ https://github.com/OneOfOne/xxhash/, I'm willing to switch the license to use Go's but before I go through gerrit I wanted to make sure there's a chance for it to be accepted.

@ianlancetaylor
Copy link
Contributor

Please ask this kind of question on golang-dev@googlegroups.com, not on the issue tracker. Thanks.

In general we are only going to add a new hash function to the standard library if it is necessary for some other piece of required functionality, or if it is clearly superior in some important way. We aren't going to add every possible hash function to the library. That's what "go get" is for.

@randall77
Copy link
Contributor

I've implemented something along those lines - it is already out for review:

https://go-review.googlesource.com/#/c/1360/

It's a mixup of cityhash and xxhash and some of my own ideas.

On Fri, Dec 12, 2014 at 11:29 AM, Ahmed W. notifications@github.com wrote:

Are there any plans to include new hash algorithms?

Mainly xxhash, I have an implementation @
https://github.com/OneOfOne/xxhash/, I'm willing to switch the license to
use Go's but before I go through gerrit I wanted to make sure there's a
chance for it to be accepted.


Reply to this email directly or view it on GitHub
#9295.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants