Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/review/git-codereview: support older version of git #9283

Closed
minux opened this issue Dec 12, 2014 · 7 comments
Closed

x/review/git-codereview: support older version of git #9283

minux opened this issue Dec 12, 2014 · 7 comments

Comments

@minux
Copy link
Member

minux commented Dec 12, 2014

According to thishttp://opensource.apple.com/source/Git/Git-17/Git.plist, the git on OS X might be as old as 1.7.4.4.

I know on OS X 10.8.5, git version shows:

git version 1.7.12.4 (Apple Git-37)

For exmaple, git-branch -q is introduced in git/git@f9a482e, which first appreas in 1.7.11. There might be OS X user with older version of git.

Because we still support OS X 10.6, ideally we should support the version of Git on 10.6.

The relevant golang-nuts question: https://groups.google.com/d/msg/golang-nuts/vKwVKAXdrWg/UzKRkQFwPycJ

@rsc
Copy link
Contributor

rsc commented Dec 12, 2014

I'm inclined to say get a newer version of Git. We only barely support 10.6. The -q flag is important.

@bradfitz
Copy link
Contributor

Most of the git additions over the years are little convenience flags that were always possible written in a different way previously, so to a small extent I'd like for us to go out of our way to support common git versions in the wild.

I think we should still support the default git on OS X 10.8. I don't have opinions on 10.7. But I agree that 10.6 is too old to care.

@adg
Copy link
Contributor

adg commented Dec 14, 2014

We should at least put a check in the tool to check that we're running a
new-enough version.

On 13 December 2014 at 09:53, Brad Fitzpatrick notifications@github.com
wrote:

Most of the git additions over the years are little convenience flags that
were always possible written in a different way previously, so to a small
extent I'd like for us to go out of our way to support common git versions
in the wild.

I think we should still support the default git on OS X 10.8. I don't have
opinions on 10.7. But I agree that 10.6 is too old to care.


Reply to this email directly or view it on GitHub
#9283 (comment).

@minux
Copy link
Member Author

minux commented Dec 14, 2014

And we probably should test using the oldest version of git supported
in the non -short test.

Andrew, IIRC, you maintain the 10.7 builders, what version of git is
installed on those builders?

I agree 10.6 is too old to support, but 10.7 is probably still used.

@adg
Copy link
Contributor

adg commented Dec 14, 2014

I'll check once I get the machine back online tomorrow.

On 15 December 2014 at 10:02, Minux Ma notifications@github.com wrote:

And we probably should test using the oldest version of git supported
in the non -short test.

Andrew, IIRC, you maintain the 10.7 builders, what version of git is
installed on those builders?

I agree 10.6 is too old to support, but 10.7 is probably still used.


Reply to this email directly or view it on GitHub
#9283 (comment).

@bradfitz
Copy link
Contributor

bradfitz commented Jan 5, 2015

I also hit this bug on the default Debian version on GCE (Wheezy), which includes git version 1.7.10.4.

For others in that situation:

I added:

deb http://ftp.de.debian.org/debian wheezy-backports main

to /etc/apt/sources.list

And then ran:

sudo apt-get install git/wheezy-backports

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc changed the title review: support older version of git x/review: support older version of git Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-review label Apr 14, 2015
@mikioh mikioh changed the title x/review: support older version of git x/review/git-codereview: support older version of git Aug 17, 2015
@rsc
Copy link
Contributor

rsc commented Jan 29, 2016

There has not been much outcry for this in the past year. Let's just wait this one out.

@rsc rsc closed this as completed Jan 29, 2016
@golang golang locked and limited conversation to collaborators Feb 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants