New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/review/git-codereview: support older version of git #9283
Comments
I'm inclined to say get a newer version of Git. We only barely support 10.6. The -q flag is important. |
Most of the git additions over the years are little convenience flags that were always possible written in a different way previously, so to a small extent I'd like for us to go out of our way to support common git versions in the wild. I think we should still support the default git on OS X 10.8. I don't have opinions on 10.7. But I agree that 10.6 is too old to care. |
We should at least put a check in the tool to check that we're running a On 13 December 2014 at 09:53, Brad Fitzpatrick notifications@github.com
|
And we probably should test using the oldest version of git supported Andrew, IIRC, you maintain the 10.7 builders, what version of git is I agree 10.6 is too old to support, but 10.7 is probably still used. |
I'll check once I get the machine back online tomorrow. On 15 December 2014 at 10:02, Minux Ma notifications@github.com wrote:
|
I also hit this bug on the default Debian version on GCE (Wheezy), which includes git version 1.7.10.4. For others in that situation: I added:
to /etc/apt/sources.list And then ran:
|
There has not been much outcry for this in the past year. Let's just wait this one out. |
According to thishttp://opensource.apple.com/source/Git/Git-17/Git.plist, the git on OS X might be as old as 1.7.4.4.
I know on OS X 10.8.5, git version shows:
For exmaple, git-branch -q is introduced in git/git@f9a482e, which first appreas in 1.7.11. There might be OS X user with older version of git.
Because we still support OS X 10.6, ideally we should support the version of Git on 10.6.
The relevant golang-nuts question: https://groups.google.com/d/msg/golang-nuts/vKwVKAXdrWg/UzKRkQFwPycJ
The text was updated successfully, but these errors were encountered: