Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile/cmd/gobind: go generate rules #9267

Closed
crawshaw opened this issue Dec 11, 2014 · 3 comments
Closed

x/mobile/cmd/gobind: go generate rules #9267

crawshaw opened this issue Dec 11, 2014 · 3 comments

Comments

@crawshaw
Copy link
Member

Given gobind is run on a Go package, it seems sensible to invoke it now with go generate:

//go:generate gobind -lang=java -odir testpkg
//go:generate gobind -lang=go -odir testpkg

@mikioh mikioh changed the title mobile/cmd/gobind: go generate rules cmd/gobind: go generate rules Jan 4, 2015
@hyangah
Copy link
Contributor

hyangah commented Jan 27, 2015

I've added -output flag and converted the bind testpkg to use the go generate. However, as thinking about objective-c gobind, I think -odir is a better option - allow to output multiple files (e.g., .h and .m files). What do you think, David? If you don't mind I will implement -odir and discourage (or remove) the use of -output flag.

@crawshaw
Copy link
Member Author

I think multiple output files per package are unavoidable for objective-c. What about Swift?

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc removed the release-none label Apr 10, 2015
@rsc rsc changed the title cmd/gobind: go generate rules x/mobile/cmd/gobind: go generate rules Apr 14, 2015
@rsc rsc modified the milestones: Unreleased, Unplanned Apr 14, 2015
@rsc rsc removed the repo-mobile label Apr 14, 2015
@hyangah
Copy link
Contributor

hyangah commented Apr 21, 2015

There is -outdir.
For swift, there is no concept of header file.

@hyangah hyangah closed this as completed Apr 21, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants