Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go generate treats \r as part of command text #9264

Closed
boombuler opened this issue Dec 11, 2014 · 4 comments
Closed

cmd/go: go generate treats \r as part of command text #9264

boombuler opened this issue Dec 11, 2014 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.4.2

Comments

@boombuler
Copy link

Just tested the new "go generate" command. I'm using a windows machine and so my line endings are \r\n and not just \n.
so if I put "//go:generate dosomething" in my source code and run "go generate" it executed "dosomething\r" which can not be found. (Tested with go1.4.windows-amd64 release)
Sorry for submitting if this is expected behavior...
@mattn
Copy link
Member

mattn commented Dec 11, 2014

Maybe, your go file may be DOS file format. It should be UNIX file format.

@boombuler
Copy link
Author

Ok it works if you run gofmt first. Looks like my editor f*cked this up. The editor replaced the \n with \r\n after it successfully executed gofmt.
Sorry for bugging you.

@mattn
Copy link
Member

mattn commented Dec 11, 2014

No prob :)

@rsc
Copy link
Contributor

rsc commented Dec 11, 2014

I believe this is a bug that we should fix. @robpike

@rsc rsc reopened this Dec 11, 2014
@rsc rsc changed the title "go generate" directives adds carriage return (U+000D) to command cmd/go: treats \r as part of command text Dec 11, 2014
@rsc rsc changed the title cmd/go: treats \r as part of command text cmd/go: go generate treats \r as part of command text Dec 11, 2014
@robpike robpike closed this as completed Dec 11, 2014
@robpike robpike reopened this Dec 11, 2014
@mattn mattn mentioned this issue Dec 12, 2014
Closed
@boombuler boombuler mentioned this issue Dec 15, 2014
Closed
@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@josharian josharian mentioned this issue Dec 16, 2014
Closed
@minux minux modified the milestones: Go1.4.2, Go1.5 Jan 31, 2015
@minux minux mentioned this issue Jan 31, 2015
Closed
robpike added a commit that referenced this issue Feb 17, 2015
@robpike @adg
[release-branch.go1.4] cmd/go: handle \r in input text
b64f8f8 
Remove carriage returns from //go:generate lines.
Carriage returns are the predecessor of BOMs and still
live on Windows.

Fixes #9264

Change-Id: I637748c74335c696b3630f52f2100061153fcdb4
Reviewed-on: https://go-review.googlesource.com/1564
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
(cherry picked from commit fde3ab8)
Reviewed-on: https://go-review.googlesource.com/4999
Reviewed-by: David Symonds <dsymonds@golang.org>
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@robpike @wheatman
[release-branch.go1.4] cmd/go: handle \r in input text
cdcfa3f 
Remove carriage returns from //go:generate lines.
Carriage returns are the predecessor of BOMs and still
live on Windows.

Fixes golang#9264

Change-Id: I637748c74335c696b3630f52f2100061153fcdb4
Reviewed-on: https://go-review.googlesource.com/1564
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
(cherry picked from commit fde3ab8)
Reviewed-on: https://go-review.googlesource.com/4999
Reviewed-by: David Symonds <dsymonds@golang.org>
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@robpike @wheatman
[release-branch.go1.4] cmd/go: handle \r in input text
a9a7644 
Remove carriage returns from //go:generate lines.
Carriage returns are the predecessor of BOMs and still
live on Windows.

Fixes golang#9264

Change-Id: I637748c74335c696b3630f52f2100061153fcdb4
Reviewed-on: https://go-review.googlesource.com/1564
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
(cherry picked from commit fde3ab8)
Reviewed-on: https://go-review.googlesource.com/4999
Reviewed-by: David Symonds <dsymonds@golang.org>
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@robpike @wheatman
[release-branch.go1.4] cmd/go: handle \r in input text
685fb2a 
Remove carriage returns from //go:generate lines.
Carriage returns are the predecessor of BOMs and still
live on Windows.

Fixes golang#9264

Change-Id: I637748c74335c696b3630f52f2100061153fcdb4
Reviewed-on: https://go-review.googlesource.com/1564
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
(cherry picked from commit fde3ab8)
Reviewed-on: https://go-review.googlesource.com/4999
Reviewed-by: David Symonds <dsymonds@golang.org>
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018
@robpike @wheatman
[release-branch.go1.4] cmd/go: handle \r in input text
149d628 
Remove carriage returns from //go:generate lines.
Carriage returns are the predecessor of BOMs and still
live on Windows.

Fixes golang#9264

Change-Id: I637748c74335c696b3630f52f2100061153fcdb4
Reviewed-on: https://go-review.googlesource.com/1564
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
(cherry picked from commit fde3ab8)
Reviewed-on: https://go-review.googlesource.com/4999
Reviewed-by: David Symonds <dsymonds@golang.org>
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@robpike @wheatman
[release-branch.go1.4] cmd/go: handle \r in input text
37395af 
Remove carriage returns from //go:generate lines.
Carriage returns are the predecessor of BOMs and still
live on Windows.

Fixes golang#9264

Change-Id: I637748c74335c696b3630f52f2100061153fcdb4
Reviewed-on: https://go-review.googlesource.com/1564
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Andrew Gerrand <adg@golang.org>
(cherry picked from commit fde3ab8)
Reviewed-on: https://go-review.googlesource.com/4999
Reviewed-by: David Symonds <dsymonds@golang.org>
@rsc rsc unassigned robpike Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4.2
Development

No branches or pull requests
8 participants
@bradfitz @mattn @rsc @minux @boombuler @ianlancetaylor @robpike @gopherbot