Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/review/git-codereview: add 'patch' subcommand #9255

Closed
adg opened this issue Dec 11, 2014 · 7 comments
Closed

x/review/git-codereview: add 'patch' subcommand #9255

adg opened this issue Dec 11, 2014 · 7 comments

Comments

@adg
Copy link
Contributor

adg commented Dec 11, 2014

Like the old 'hg clpatch'.

@mattn
Copy link
Member

mattn commented Dec 11, 2014

This should be posted to https://github.com/golang/review/ ?

@rsc rsc closed this as completed Dec 11, 2014
@rsc rsc reopened this Dec 11, 2014
@minux
Copy link
Member

minux commented Dec 11, 2014

@mattn, no, all issues for Go and sub-repos should be reported here.
(You will notice that the issue tracker for golang/review is disabled.)

@mattn
Copy link
Member

mattn commented Dec 11, 2014

Yes, I noticed it just now.

@paranoiacblack paranoiacblack changed the title review: add 'patch' subcomand review: add 'patch' subcommand Dec 11, 2014
@paranoiacblack paranoiacblack self-assigned this Dec 11, 2014
@josharian
Copy link
Contributor

@paranoiacblack working on this?

@paranoiacblack
Copy link
Contributor

See the comments on https://go-review.googlesource.com/#/c/1410/. It isn't clear what exactly this command should do or if it necessary.

@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@mikioh mikioh changed the title review: add 'patch' subcommand x/review/git-codereview: add 'patch' subcommand Aug 17, 2015
@cmarcelo
Copy link
Contributor

cmarcelo commented Mar 1, 2016

Taking into account @rsc comments from previous CL, I've mailed https://go-review.googlesource.com/#/c/20101

Opted for detached checkout instead of creating branches to avoid the problem of having a special branches that we could decide to handle differently in every command: "what sync means in cl.1401.2", "if I change cl.1401, will the new sync lose my changes due to a newer version online?", and so on.

For the case of trying a CL which seems the common case, detached seems enough; the user can always create a new branch on top of that.

@gopherbot
Copy link

CL https://golang.org/cl/20101 mentions this issue.

@golang golang locked and limited conversation to collaborators Sep 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants