New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/review/git-codereview: add 'patch' subcommand #9255
Comments
This should be posted to https://github.com/golang/review/ ? |
@mattn, no, all issues for Go and sub-repos should be reported here. |
Yes, I noticed it just now. |
@paranoiacblack working on this? |
See the comments on https://go-review.googlesource.com/#/c/1410/. It isn't clear what exactly this command should do or if it necessary. |
Taking into account @rsc comments from previous CL, I've mailed https://go-review.googlesource.com/#/c/20101 Opted for detached checkout instead of creating branches to avoid the problem of having a special branches that we could decide to handle differently in every command: "what sync means in cl.1401.2", "if I change cl.1401, will the new sync lose my changes due to a newer version online?", and so on. For the case of trying a CL which seems the common case, detached seems enough; the user can always create a new branch on top of that. |
CL https://golang.org/cl/20101 mentions this issue. |
Like the old 'hg clpatch'.
The text was updated successfully, but these errors were encountered: