Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/cmd/godoc: bad formatting with -src flag #9247

Closed
ghost opened this issue Dec 10, 2014 · 2 comments
Closed

x/tools/cmd/godoc: bad formatting with -src flag #9247

ghost opened this issue Dec 10, 2014 · 2 comments

Comments

@ghost
Copy link

ghost commented Dec 10, 2014

There is no separation between matched functions when using the -src flag. See example output after running godoc -src bytes WriteTo below:

// WriteTo writes data to w until the buffer is drained or an error occurs.
// The return value n is the number of bytes written; it always fits into an
// int, but it is int64 to match the io.WriterTo interface. Any error
// encountered during the write is also returned.
func (b *Buffer) WriteTo(w io.Writer) (n int64, err error) {
    ...
}// WriteTo implements the io.WriterTo interface.
func (r *Reader) WriteTo(w io.Writer) (n int64, err error) {
    ...
}
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc removed the release-none label Apr 10, 2015
@rsc rsc changed the title cmd/godoc: bad formatting with -src flag x/tools/cmd/godoc: bad formatting with -src flag Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@0xmohit
Copy link
Contributor

0xmohit commented Oct 26, 2015

This doesn't seem to be an issue with go1.5.1.

// WriteTo writes data to w until the buffer is drained or an error occurs.
// The return value n is the number of bytes written; it always fits into an
// int, but it is int64 to match the io.WriterTo interface. Any error
// encountered during the write is also returned.
func (b *Buffer) WriteTo(w io.Writer) (n int64, err error) {
    ...
}

// WriteTo implements the io.WriterTo interface.
func (r *Reader) WriteTo(w io.Writer) (n int64, err error) {
    ...
}

@ALTree
Copy link
Member

ALTree commented Jan 13, 2017

Same as #9726, fixed by CL 7681.

@ALTree ALTree closed this as completed Jan 13, 2017
@golang golang locked and limited conversation to collaborators Jan 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants