New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: redeclaration errors after switching branches #9231
Comments
Also, after the failed make.bash,
|
Yes, running |
We gitignore all the runtime/z_.go files. Some of them are still around, On Tue, Dec 9, 2014 at 4:32 PM, Brad Fitzpatrick notifications@github.com
|
The What's the more specific pattern we should ignore? |
We used to remove z* in cmd/dist but now there are go generate-generated z |
Looks like just:
? |
Yes, that is the correct list. |
I also hit this issue several times and all of the trouble is caused by zruntime_defs_darwin_amd64.go. |
Can we have cmd/dist not do any deleting at all, and just build the right files instead of building whatever it finds on disk? (Sorry, I forget how this all works.) |
@bradfitz, because cmd/go also need to be able to build runtime, we will also If you are concerned about deleting files, what about make cmd/dist warn if it |
I defer to Russ. |
just run into this issue today, Brad's steps fixed my issue but it would have been nice to know what's going on/clean up the files for me, instead of googling the error :) |
I'm running into this one when trying to upgrade from Go 1.7.1 to 1.7.3 via go1.4-bootstrap-20161024 |
@c4milo, um, what are you doing? Are you mixing the Go 1.4 sources atop the Go 1.7 sources? I think you're using the bootstrap code incorrectly. |
@bradfitz, you are right, I didn't remember quite well how the bootstrap process worked. I was able to upgrade to 1.7.3 successfully using go1.4-bootstrap-20161024. Thanks! |
I ran into this by git clone $GO_REPO go
cd go
git checkout go1.4 # I meant to do 1.11beta1
cd src
./make.bash # already have GOROOT_BOOTSTRAP, so it's k
^C
git checkout go1.11beta1
./make.bash # fails because the repo is dirty |
I had to revert to go1.4 yesterday because cross-compiling was (or is) broken, and now master won't build, revealing that we might be .gitignoring too many files.
git status shows I have a clean tree at tip, but the build suggests otherwise:
Is it this line of .gitignore that's too ignore-y?
?
The text was updated successfully, but these errors were encountered: