Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: builtin DNS stub resolver behaves case sensitive and gives "no such host" #9215

Closed
gopherbot opened this issue Dec 6, 2014 · 2 comments
Closed

net: builtin DNS stub resolver behaves case sensitive and gives "no such host" #9215

gopherbot opened this issue Dec 6, 2014 · 2 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@gopherbot
Copy link

by russmackdev:

What does 'go version' print?
go version go1.4rc2 linux/amd64

What steps reproduce the problem?
If possible, include a link to a program on play.golang.org.

1. http://play.golang.org/p/0kQQT1Qz40

What happened?
Some DNS responses are capitalised eg:
&{{www4.L.GOOGLE.com. 1 1 153 4} 2915202115}
The comparison with lowercase name fails resulting in "no such host".

What should have happened instead?
The comparison should not fail, and the host should be acknowledged as found.

Please provide any additional information below.
Patch attached.

Attachments:

  1. dnsclient.go.patch (166 bytes)
@gopherbot gopherbot added the new label Dec 6, 2014
@ianlancetaylor
Copy link
Contributor

For the record, the string comparison in question is in net/dnsclient.go in the function answer.

@mikioh
Copy link
Contributor

mikioh commented Dec 11, 2014

fyi: http://tools.ietf.org/html/rfc4343

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@mikioh mikioh changed the title net: dnsclient.go header name is sometimes uppercase - gives "no such host" net: builtin DNS stub resolver behaves case sensitive and gives "no such host" Dec 20, 2014
@mikioh mikioh closed this as completed in 826fa06 Feb 3, 2015
@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@bradfitz @mikioh @ianlancetaylor @gopherbot