-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/pprof: runtime panic index out of range if given empty cpu.prof #9207
Comments
Comment 3 by jgardner@izeni.com: It wasn't intentional for the profile file to be empty but it was and that explains the crash I think too. |
encounter same issue :( |
I'd like to try my hand at this. Seems like a perfect issue for a first-timer. |
Sure, please go ahead. The contribution guideline is here: Please note that it's not as simple as adding a check for |
I actually ended up with a simple check for len() == 0, only carefully placed. See golang.org/cl/2571. There was already a fair bit of checking for malformed data there but this particular case was missed. |
Clickable link: http://golang.org/cl/2571 |
CL https://golang.org/cl/2571 mentions this issue. |
by jgardner@izeni.com:
Attachments:
The text was updated successfully, but these errors were encountered: