Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/mobile/gl: typos in WriteMat4 #9151

Closed
nbehary opened this issue Nov 22, 2014 · 3 comments
Closed

x/mobile/gl: typos in WriteMat4 #9151

nbehary opened this issue Nov 22, 2014 · 3 comments

Comments

@nbehary
Copy link

nbehary commented Nov 22, 2014

The calculations for the indexes into the target matrix, "m" multiply by 3
rather than 4 which causes every n*3 entry to be overwritten and for the last 4 entries
to always be 0.  ie:

 m[0*3+3] = p[3][0]
 m[1*3+0] = p[0][1]

Both assign to entry 3, where: 


 m[0*4+3] = p[3][0]
 m[1*4+0] = p[0][1]

Properly assign to entries 3 and 4.
@minux
Copy link
Member

minux commented Nov 23, 2014

Comment 1:

Labels changed: added release-none, repo-mobile.

Status changed to Accepted.

@gopherbot
Copy link

Comment 3:

CL https://golang.org/cl/180160043 mentions this issue.

@minux
Copy link
Member

minux commented Nov 23, 2014

Comment 4:

This issue was closed by revision golang/mobile@f456aa4.

Status changed to Fixed.

@mikioh mikioh changed the title go.mobile/gl: typos in WriteMat4 x/mobile/gl: typos in WriteMat4 Aug 5, 2015
@golang golang locked and limited conversation to collaborators Aug 5, 2016
imWildCat pushed a commit to imWildCat/go-mobile that referenced this issue Apr 10, 2021
Fixes golang/go#9151.

LGTM=crawshaw
R=crawshaw, nathan.behary
CC=golang-codereviews
https://golang.org/cl/180160043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants