Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: remove leftover traces of perl-specific commands for windows pprof #9149

Closed
jscrockett01 opened this issue Nov 21, 2014 · 4 comments
Closed

cmd/go: remove leftover traces of perl-specific commands for windows pprof #9149

jscrockett01 opened this issue Nov 21, 2014 · 4 comments
Labels
FrozenDueToAge
Milestone
Go1.4

Comments

@jscrockett01
Copy link 

When the pprof tool was rewritten in Go it stopped working in windows (see log below).

The problem can be fixed by removing the condition `&& toolName !=
"pprof"` from line 50 of cmd/go/tool.go and also by removing the entire if
block on lines 94-103 of cmd/go/tool.go beginning with `if toolIsWindows &&
toolName == "pprof"`.

Thanks for the great language!  I've been a careful follower since the blog post on day
1.

John C.
------------------

C:\>go version
go version go1.4rc1 windows/amd64

C:\>go tool
6a
6c
6g
6l
addr2line
cgo
cover
dist
fix
nm
objdump
pack
pprof
tour
vet
yacc

C:\>go tool pprof
go tool: no such tool "pprof"
@minux
Copy link
Member

minux commented Nov 21, 2014

Comment 1:

CL coming soon.

Labels changed: added release-go1.4, repo-main.

Owner changed to @minux.

Status changed to Accepted.

@gopherbot
Copy link

Comment 2:

CL https://golang.org/cl/176170043 mentions this issue.

@minux
Copy link
Member

minux commented Nov 22, 2014

Comment 3:

This issue was closed by revision 8cda58c.

Status changed to Fixed.

@rsc
Copy link
Contributor

rsc commented Nov 22, 2014

Comment 4:

This issue was closed by revision e08b7ca1d03a.

@rsc rsc added this to the Go1.4 milestone Apr 14, 2015
@rsc rsc removed the release-go1.4 label Apr 14, 2015
rsc added a commit that referenced this issue May 11, 2015
@rsc
[release-branch.go1.4] cmd/go: fix running pprof on windows.
f681812 
««« CL 176170043 / 61bbf19823d5
cmd/go: fix running pprof on windows.

Fixes #9149.

LGTM=alex.brainman, rsc
R=rsc, dave, alex.brainman
CC=golang-codereviews
https://golang.org/cl/176170043

»»»

TBR=minux
CC=golang-codereviews
https://golang.org/cl/175550043
@golang golang locked and limited conversation to collaborators Jun 25, 2016
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 25, 2018
@rsc @wheatman
[release-branch.go1.4] cmd/go: fix running pprof on windows.
a868cc0 
««« CL 176170043 / 61bbf19823d5
cmd/go: fix running pprof on windows.

Fixes golang#9149.

LGTM=alex.brainman, rsc
R=rsc, dave, alex.brainman
CC=golang-codereviews
https://golang.org/cl/176170043

»»»

TBR=minux
CC=golang-codereviews
https://golang.org/cl/175550043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jun 26, 2018
@rsc @wheatman
[release-branch.go1.4] cmd/go: fix running pprof on windows.
bb4dd3e 
««« CL 176170043 / 61bbf19823d5
cmd/go: fix running pprof on windows.

Fixes golang#9149.

LGTM=alex.brainman, rsc
R=rsc, dave, alex.brainman
CC=golang-codereviews
https://golang.org/cl/176170043

»»»

TBR=minux
CC=golang-codereviews
https://golang.org/cl/175550043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 9, 2018
@rsc @wheatman
[release-branch.go1.4] cmd/go: fix running pprof on windows.
369f5fc 
««« CL 176170043 / 61bbf19823d5
cmd/go: fix running pprof on windows.

Fixes golang#9149.

LGTM=alex.brainman, rsc
R=rsc, dave, alex.brainman
CC=golang-codereviews
https://golang.org/cl/176170043

»»»

TBR=minux
CC=golang-codereviews
https://golang.org/cl/175550043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 20, 2018
@rsc @wheatman
[release-branch.go1.4] cmd/go: fix running pprof on windows.
9c37de8 
««« CL 176170043 / 61bbf19823d5
cmd/go: fix running pprof on windows.

Fixes golang#9149.

LGTM=alex.brainman, rsc
R=rsc, dave, alex.brainman
CC=golang-codereviews
https://golang.org/cl/176170043

»»»

TBR=minux
CC=golang-codereviews
https://golang.org/cl/175550043
wheatman pushed a commit to wheatman/go-akaros that referenced this issue Jul 30, 2018
@rsc @wheatman
[release-branch.go1.4] cmd/go: fix running pprof on windows.
6b2cdd6 
««« CL 176170043 / 61bbf19823d5
cmd/go: fix running pprof on windows.

Fixes golang#9149.

LGTM=alex.brainman, rsc
R=rsc, dave, alex.brainman
CC=golang-codereviews
https://golang.org/cl/176170043

»»»

TBR=minux
CC=golang-codereviews
https://golang.org/cl/175550043
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.4
Development

No branches or pull requests
4 participants
@rsc @minux @gopherbot @jscrockett01