Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: go get fetches 'tip' of go.tools for Go 1.3.3 installation #9128

Closed
gopherbot opened this issue Nov 19, 2014 · 3 comments
Closed

cmd/go: go get fetches 'tip' of go.tools for Go 1.3.3 installation #9128

gopherbot opened this issue Nov 19, 2014 · 3 comments
Milestone

Comments

@gopherbot
Copy link

by beau.brueggemann:

To reproduce the problem:

1. Do a fresh installation of the latest Go release (1.3.3) from source, as described in
http://golang.org/doc/install/source

2. Install all the tools with 'go get code.google.com/p/go.tools/cmd/...' (again as
described in http://golang.org/doc/install/source).


What happened?

Running 'go version' prints:
'go version go1.3.3 linux/amd'

But running 'cd $GOPATH/src/code.google.com/p/go.tools/; hg branch' prints:
'default'


What should have happened instead?

Running 'hg branch' in the go.tools repo should print:
'release-branch.go1.3'


Additional information

This causes problems with tools such as godoc.  For example, browsing the source for the
standard library using 'godoc -http=:6060' doesn't work, as godoc looks in the 1.4
source location '/src/...', instead of the 1.3 location '/src/pkg/...'.  Worse still,
you can not even correct the URL in your browser by hand, as godoc will always redirect
'/src/pkg/...' to '/src/...'!
@ianlancetaylor
Copy link
Contributor

Comment 1:

Labels changed: added repo-tools, release-none.

@bradfitz bradfitz removed the new label Dec 18, 2014
@rsc rsc added this to the Unplanned milestone Apr 10, 2015
@rsc rsc removed the release-none label Apr 10, 2015
@rsc rsc changed the title go.tools: Go get fetches 'tip' for Go 1.3.3 installation x/tools: Go get fetches 'tip' for Go 1.3.3 installation Apr 14, 2015
@rsc
Copy link
Contributor

rsc commented Apr 14, 2015

I am pretty sure this is working as intended, but I will leave it open and come back when I have a little more time to think. The release-branch tag is for building a release, not for go get.

@rsc rsc changed the title x/tools: Go get fetches 'tip' for Go 1.3.3 installation cmd/go: go get fetches 'tip' of go.tools for Go 1.3.3 installation Apr 14, 2015
@rsc rsc modified the milestones: Go1.5, Unplanned Apr 14, 2015
@rsc rsc removed the repo-tools label Apr 14, 2015
@rsc
Copy link
Contributor

rsc commented Jun 29, 2015

Yes, what I wrote before is true.

@rsc rsc closed this as completed Jun 29, 2015
@golang golang locked and limited conversation to collaborators Jun 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants