Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAIL: os_test.TestSeek #91

Closed
gopherbot opened this issue Nov 12, 2009 · 8 comments
Closed

FAIL: os_test.TestSeek #91

gopherbot opened this issue Nov 12, 2009 · 8 comments

Comments

@gopherbot
Copy link

by david.titarenco:

What steps will reproduce the problem?
./all.bash

What is the expected output? What do you see instead?
gopack grc _test/os.a _gotest_.8
make[2]: Leaving directory `/home/go/src/pkg/os'
--- FAIL: os_test.TestSeek
        #6: Seek(1099511627776, 0) = 0, seek _obj/seektest: invalid
argument want 1099511627776,
        #7: Seek(1099511627776, 2) = 0, seek _obj/seektest: invalid
argument want 1099511627789,
FAIL
make[1]: *** [test] Error 1
make[1]: Leaving directory `/home/go/src/pkg/os'
make: *** [os.test] Error 2

What is your $GOOS?  $GOARCH?
GOARCH=386
GOOS=linux

Which revision are you sync'ed to?  (hg log -l 1)
4009:3732030c7584

Please provide any additional information below.
I know this is just a test (and everything does seem to have installed
properly), I'm just giving the dev team a heads up.
@rsc
Copy link
Contributor

rsc commented Nov 12, 2009

Comment 1:

Thanks.  What file system are you using?  I suspect that the file system is rejecting
the 
seek offset, since this test works on 386/linux for us on other machines and using NFS.

Owner changed to r...@golang.org.

Status changed to WaitingForReply.

@gopherbot
Copy link
Author

Comment 2 by thehanse:

I got the same error.
GOARCH=amd64
GOOS=linux
changeset:   3975:b51fd2d6c160
I use ext3 on my machine.

@gopherbot
Copy link
Author

Comment 3 by david.titarenco:

/dev/vzfs on / type reiserfs (rw,usrquota,grpquota)

@rsc
Copy link
Contributor

rsc commented Nov 12, 2009

Comment 4:

Status changed to Started.

@rsc
Copy link
Contributor

rsc commented Nov 12, 2009

Comment 5:

Could you please try this?  In $GOROOT/src/pkg/os/os_test.go there
are two lines that say
        test{1 << 40, 0, 1 << 40},
        test{1 << 40, 2, 1<<40 + int64(len(data))},
Please try changing all 4 instances of 1<<40 with 1<<33.
The test is trying to check that 64-bit offsets work correctly;
perhaps backing down from 1TB to 8GB will make reiserfs happy.
Thanks.

Status changed to WaitingForReply.

@gopherbot
Copy link
Author

Comment 6 by david.titarenco:

Yep, that seemed to have worked.
Should I submit a CL with the updated os_test.go?

@gopherbot
Copy link
Author

Comment 7 by david.titarenco:

Yep, that seemed to have worked!

@rsc
Copy link
Contributor

rsc commented Nov 12, 2009

Comment 8:

Thanks for checking.  That change will be in the next release.

Status changed to Fixed.

minux pushed a commit to minux/goios that referenced this issue Feb 27, 2015
Update golang#91

- Update mksysnum and zsysnum, remove obsolete syscall numbers
- Replace obsolete syscalls with forwarding methods
- For the remaining calls, temporarily move their definition to xsyscall_linux_arm64.go
@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc removed their assignment Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants