Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: SWIG warnings aren't printed #9053

Closed
michael-schaller opened this issue Nov 3, 2014 · 8 comments
Closed

cmd/go: SWIG warnings aren't printed #9053

michael-schaller opened this issue Nov 3, 2014 · 8 comments
Labels
FrozenDueToAge
Milestone
Go1.5

Comments

@michael-schaller
Copy link
Contributor 

What does 'go version' print? 1.3.3


What steps reproduce the problem?
If possible, include a link to a program on play.golang.org.

1. Generate swig code that yields a warning
2. Run 'go build' or 'go test'


What happened?
The 'go' tool hid the SWIG warning message(s).
For the attached example the following warning was expected:
example.swigcxx:21: Warning 325: Nested class not currently supported (Inner ignored)


What should have happened instead?
The 'go' tool should have shown the SWIG warning message(s).
For the attached example the following warning was expected:
example.swigcxx:21: Warning 325: Nested class not currently supported (Inner ignored)


Please see the attached example code to reproduce the issue.

The problematic code is here:
https://code.google.com/p/go/source/browse/src/cmd/go/build.go#2577

The problematic code block should be extended with this code to fix the issue:
if len(out) > 0 {
    b.showOutput(p.Dir, p.ImportPath, b.processOutput(out))
}

Attachments:

  1. example.tar.gz (525 bytes)
@ianlancetaylor
Copy link
Contributor

Comment 1:

Labels changed: added repo-main, release-go1.5.

@michael-schaller
Copy link
Contributor Author

Comment 2:

Note regarding the example:
The example was tested with SWIG 3.0.2 but any SWIG version supported by Go should
exhibit this issue.

@ianlancetaylor
Copy link
Contributor

Comment 4:

Please send patches using the procedure described at
http://golang.org/doc/contribute.html.  Thanks.
We probably won't look at this until after the 1.4 release is out, though.

@gopherbot
Copy link

Comment 5:

CL https://golang.org/cl/167290043 mentions this issue.

@michael-schaller
Copy link
Contributor Author

Comment 6:

I've sent the patch for review: https://golang.org/cl/167290043
Please let me know if anything is missing as this is the first time I'm contributing to
the Go project.
No worries regarding the timeline. Fixing this for Go 1.5 is fine albeit I would prefer
if it would also be fixed in earlier releases. ;-)

@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@michael-schaller
Copy link
Contributor Author

I've tried to open a new code review according to the new Contribution Guidelines but the current master has issues with SWIG. I've opened issue #9410 for this new issue.

@michael-schaller
Copy link
Contributor Author

Nearly forgot about this one.
Review link: https://go-review.googlesource.com/8400

@michael-schaller
Copy link
Contributor Author

Ian, thanks for the review. Wish you a nice Easter weekend.

@golang golang locked and limited conversation to collaborators Jun 25, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.5
Development

No branches or pull requests
4 participants
@bradfitz @michael-schaller @ianlancetaylor @gopherbot