Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/objdump: no support for ppc64{,le} #9039

Closed
davecheney opened this issue Nov 1, 2014 · 8 comments
Closed

cmd/objdump: no support for ppc64{,le} #9039

davecheney opened this issue Nov 1, 2014 · 8 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.8

Comments

@davecheney
Copy link
Contributor 

What steps will reproduce the problem?

--- FAIL: TestObjDump (0.90s)
        objdump_test.go:56: go tool objdump /tmp/go-build428711172/cmd/objdump/_test/objdump.test: exit status 1
                objdump: reading /tmp/go-build428711172/cmd/objdump/_test/objdump.test: unknown architecture
--- FAIL: TestDisasm (0.94s)
        objdump_test.go:185: objdump fmthello.exe: exit status 1
                objdump: reading /tmp/TestObjDump069071063/hello.exe: unknown architecture
FAIL
exit status 1
FAIL    cmd/objdump     1.852s


What is the expected output? What do you see instead?


Please use labels and text to provide additional information.
@aclements aclements mentioned this issue Dec 9, 2014
Closed
@bradfitz bradfitz modified the milestone: Go1.5 Dec 16, 2014
@aclements aclements self-assigned this Dec 22, 2014
@minux minux assigned minux and unassigned aclements May 4, 2015
@gopherbot
Copy link

CL https://golang.org/cl/9683 mentions this issue.

@rsc rsc modified the milestones: Go1.6Early, Go1.5 Jul 21, 2015
@ianlancetaylor ianlancetaylor modified the milestones: Go1.6, Go1.6Early Dec 11, 2015
@rsc rsc modified the milestones: Unplanned, Go1.6 Dec 11, 2015
@minux minux mentioned this issue Mar 24, 2016
Closed
@laboger
Copy link
Contributor

laboger commented May 11, 2016

I see this is marked Unplanned but has been marked and unmarked as being included in releases since Go1.5. I agree it is not a high priority but Minux has already done most of the work so it would be nice to make it available for others to use.

@bradfitz bradfitz changed the title cmd/objdump: no support for power64{,le} cmd/objdump: no support for ppc64{,le} May 11, 2016
@bradfitz bradfitz modified the milestones: Go1.8, Unplanned May 11, 2016
@laboger
Copy link
Contributor

laboger commented May 11, 2016

Let me add that I've been using the code that Minux pointed me to (a long time ago) with some minor modifications and it is working for me. If his code was put into golang.org/x/arch/ppc64 after changing the strings from power64 to ppc64, then there are just a few other minor changes to get objump and the testcase to work on ppc64x and I can finish those if necessary. For now if it could be put into golang.org/x/arch (not sure if that is frozen too?) that would make it easier to use and the rest could be done later for Go 1.8.

@laboger
Copy link
Contributor

laboger commented Jul 26, 2016

What's the outlook for getting this into Go 1.8?

@dr2chase
Copy link
Contributor

At least for the timing, the outlook for 1.8 is fine.

@minux
Copy link
Member

minux commented Jul 27, 2016 via email

@quentinmit quentinmit added the NeedsFix The path to resolution is known, but the work has not been done. label Oct 6, 2016
@laboger
Copy link
Contributor

laboger commented Oct 7, 2016

Is this still going to make Go 1.8?

@gopherbot
Copy link

CL https://golang.org/cl/30936 mentions this issue.

gopherbot pushed a commit that referenced this issue Oct 13, 2016
@rsc
cmd: add golang.org/x/arch/ppc64/ppc64asm for disassembly
ed0a956 
For #9039.

Change-Id: I2b1bcd76857ff332411ca21a0cc5def3097a8eaf
Reviewed-on: https://go-review.googlesource.com/30936
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@golang golang locked and limited conversation to collaborators Oct 13, 2017
@rsc rsc unassigned minux Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.8
Development

No branches or pull requests
10 participants
@bradfitz @davecheney @rsc @quentinmit @minux @dr2chase @aclements @ianlancetaylor @gopherbot @laboger